third_party/WebKit/Source/modules/webusb/USB.h - Issue 1848603002: Remove single observer assumption in WebUSBClient.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webusb/USB.h

Issue 1848603002: Remove single observer assumption in WebUSBClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use EAGERLY_FINALIZE() instead. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef USB_h	5 #ifndef USB_h

6 #define USB_h	6 #define USB_h

7	7

8 #include "bindings/core/v8/ScriptPromise.h"	8 #include "bindings/core/v8/ScriptPromise.h"

9 #include "bindings/core/v8/ScriptWrappable.h"	9 #include "bindings/core/v8/ScriptWrappable.h"

10 #include "core/events/EventTarget.h"	10 #include "core/events/EventTarget.h"

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45 const AtomicString& interfaceName() const override;	45 const AtomicString& interfaceName() const override;

46	46

47 // LocalFrameLifecycleObserver overrides.	47 // LocalFrameLifecycleObserver overrides.

48 void willDetachFrameHost() override;	48 void willDetachFrameHost() override;

49	49

50 // WebUSBClient::Observer overrides.	50 // WebUSBClient::Observer overrides.

51 void onDeviceConnected(WebPassOwnPtr<WebUSBDevice>) override;	51 void onDeviceConnected(WebPassOwnPtr<WebUSBDevice>) override;

52 void onDeviceDisconnected(WebPassOwnPtr<WebUSBDevice>) override;	52 void onDeviceDisconnected(WebPassOwnPtr<WebUSBDevice>) override;

53	53

54 DECLARE_VIRTUAL_TRACE();	54 DECLARE_VIRTUAL_TRACE();

	55 EAGERLY_FINALIZE();

55	56

56 private:	57 private:

57 explicit USB(LocalFrame& frame);	58 explicit USB(LocalFrame& frame);

58	59

59 WebUSBClient* m_client;	60 WebUSBClient* m_client;

60 };	61 };

61	62

62 } // namespace blink	63 } // namespace blink

63	64

64 #endif // USB_h	65 #endif // USB_h

OLD	NEW

« content/renderer/usb/web_usb_client_impl.cc ('K') | « content/renderer/usb/web_usb_client_impl.cc ('k') | third_party/WebKit/Source/modules/webusb/USB.cpp » ('j') | no next file with comments »