Remove single observer assumption in WebUSBClient.

content/renderer/usb/web_usb_client_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/usb/web_usb_client_impl.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 105 matching lines @@
 
   mojo::Array<device::usb::DeviceFilterPtr> device_filters =
       mojo::Array<device::usb::DeviceFilterPtr>::From(options.filters);
 
   chooser_service_->GetPermission(
       std::move(device_filters),
       base::Bind(&OnRequestDevicesComplete, base::Passed(&scoped_callbacks),
                  base::Unretained(device_manager_.get())));
 }
 
-void WebUSBClientImpl::setObserver(Observer* observer) {
-  if (!observer_) {
+void WebUSBClientImpl::addObserver(Observer* observer) {
+  if (observers_.empty()) {
     // Set up two sequential calls to GetDeviceChanges to avoid latency.
     device::usb::DeviceManager* device_manager = GetDeviceManager();
     device_manager->GetDeviceChanges(base::Bind(
         &WebUSBClientImpl::OnDeviceChangeNotification, base::Unretained(this)));
     device_manager->GetDeviceChanges(base::Bind(
         &WebUSBClientImpl::OnDeviceChangeNotification, base::Unretained(this)));
   }
 
-  observer_ = observer;
+  observers_.insert(observer);

[sof, 2016/04/02 07:02:17]

It sounds as if this code won't stay around for long, but.. would a DCHECK() on
non-membership be worthwhile?

+}
+
+void WebUSBClientImpl::removeObserver(Observer* observer) {
+  DCHECK(ContainsKey(observers_, observer));
+  observers_.erase(observer);
 }
 
 device::usb::DeviceManager* WebUSBClientImpl::GetDeviceManager() {
   if (!device_manager_)
     service_registry_->ConnectToRemoteService(mojo::GetProxy(&device_manager_));
   return device_manager_.get();
 }
 
 void WebUSBClientImpl::OnDeviceChangeNotification(
     device::usb::DeviceChangeNotificationPtr notification) {
-  if (!observer_)
+  if (observers_.empty())
     return;
 
   device_manager_->GetDeviceChanges(base::Bind(
       &WebUSBClientImpl::OnDeviceChangeNotification, base::Unretained(this)));
   for (size_t i = 0; i < notification->devices_added.size(); ++i) {
     const device::usb::DeviceInfoPtr& device_info =
         notification->devices_added[i];
-    device::usb::DevicePtr device;
-    device_manager_->GetDevice(device_info->guid, mojo::GetProxy(&device));
-    observer_->onDeviceConnected(blink::adoptWebPtr(new WebUSBDeviceImpl(
-        std::move(device),
-        mojo::ConvertTo<blink::WebUSBDeviceInfo>(device_info))));
+    for (auto observer : observers_) {
+      device::usb::DevicePtr device;
+      device_manager_->GetDevice(device_info->guid, mojo::GetProxy(&device));
+      observer->onDeviceConnected(blink::adoptWebPtr(new WebUSBDeviceImpl(
+          std::move(device),
+          mojo::ConvertTo<blink::WebUSBDeviceInfo>(device_info))));
+    }
   }
   for (size_t i = 0; i < notification->devices_removed.size(); ++i) {
     const device::usb::DeviceInfoPtr& device_info =
         notification->devices_removed[i];
-    observer_->onDeviceDisconnected(blink::adoptWebPtr(new WebUSBDeviceImpl(
-        nullptr, mojo::ConvertTo<blink::WebUSBDeviceInfo>(device_info))));
+    for (auto observer : observers_)
+      observer->onDeviceDisconnected(blink::adoptWebPtr(new WebUSBDeviceImpl(
+          nullptr, mojo::ConvertTo<blink::WebUSBDeviceInfo>(device_info))));
   }
 }
 
 }  // namespace content