chrome/browser/themes/browser_theme_pack_unittest.cc - Issue 18486007: Fix the misalignment on CrOS of the tab background images

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/themes/browser_theme_pack_unittest.cc

Issue 18486007: Fix the misalignment on CrOS of the tab background images (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/themes/browser_theme_pack_unittest.cc

diff --git a/chrome/browser/themes/browser_theme_pack_unittest.cc b/chrome/browser/themes/browser_theme_pack_unittest.cc

index b2fd658e4acada05ae34ac29e3211ef753d1b845..40d235d03210c87f5818d006e1f600d9dfdeffb2 100644

--- a/chrome/browser/themes/browser_theme_pack_unittest.cc

+++ b/chrome/browser/themes/browser_theme_pack_unittest.cc

@@ -223,7 +223,7 @@ class BrowserThemePackTest : public ::testing::Test {

EXPECT_TRUE(pack->HasCustomImage(IDR_THEME_BUTTON_BACKGROUND));

EXPECT_TRUE(pack->HasCustomImage(IDR_THEME_FRAME));

EXPECT_TRUE(pack->HasCustomImage(IDR_THEME_NTP_BACKGROUND));

- EXPECT_TRUE(pack->HasCustomImage(IDR_THEME_TAB_BACKGROUND));

+ EXPECT_TRUE(pack->HasCustomImage(IDR_THEME_TAB_BACKGROUND_OVERLAY));

EXPECT_TRUE(pack->HasCustomImage(IDR_THEME_TOOLBAR));

EXPECT_TRUE(pack->HasCustomImage(IDR_THEME_WINDOW_CONTROL_BACKGROUND));

@@ -233,6 +233,9 @@ class BrowserThemePackTest : public ::testing::Test {

EXPECT_FALSE(pack->HasCustomImage(IDR_THEME_FRAME_INACTIVE));

EXPECT_FALSE(pack->HasCustomImage(IDR_THEME_FRAME_INCOGNITO));

EXPECT_FALSE(pack->HasCustomImage(IDR_THEME_FRAME_INCOGNITO_INACTIVE));

+ EXPECT_FALSE(pack->HasCustomImage(

+ IDR_THEME_TAB_BACKGROUND_INCOGNITO_OVERLAY));

+ EXPECT_FALSE(pack->HasCustomImage(IDR_THEME_TAB_BACKGROUND));

EXPECT_FALSE(pack->HasCustomImage(IDR_THEME_TAB_BACKGROUND_INCOGNITO));

// Make sure we don't have phantom data.