Fix errorprone javac path for GN.

Fix errorprone javac path for GN.

BUG=598708
Committed: https://crrev.com/0004417d4afcda9eb26321b778009357ba5ca2b5
Cr-Commit-Position: refs/heads/master@{#384423}

[mikecase (-- gone --), 2016-03-30 21:24:48]

mikecase@chromium.org changed reviewers:
+ jbudorick@chromium.org, rnephew@chromium.org

[mikecase (-- gone --), 2016-03-30 21:24:48]

Don't know if there is a cleaner way to get the path of the output jar for the
errorprone:javac_java target, but this needs to be used as the bootclasspath
when running errorprone.

Currently the wrong path is being used.

[jbudorick, 2016-03-30 21:32:39]

jbudorick@chromium.org changed reviewers:
+ agrieve@chromium.org

[jbudorick, 2016-03-30 21:32:40]

+agrieve

[agrieve, 2016-03-31 00:22:47]

https://codereview.chromium.org/1848593002/diff/1/third_party/errorprone/BUIL...
File third_party/errorprone/BUILD.gn (right):

https://codereview.chromium.org/1848593002/diff/1/third_party/errorprone/BUIL...
third_party/errorprone/BUILD.gn:46: bootclasspath = rebase_path(
GN should raise errors when paths to non-existent files exist. In this case, I
think it's because java_prebuilt_impl is not adding bootclasspath to its list of
inputs.

Could you also update the template to do so so that this will be caught next
time?

[mikecase (-- gone --), 2016-03-31 18:02:29]

https://codereview.chromium.org/1848593002/diff/1/third_party/errorprone/BUIL...
File third_party/errorprone/BUILD.gn (right):

https://codereview.chromium.org/1848593002/diff/1/third_party/errorprone/BUIL...
third_party/errorprone/BUILD.gn:46: bootclasspath = rebase_path(
On 2016/03/31 at 00:22:46, agrieve wrote:
> GN should raise errors when paths to non-existent files exist. In this case, I
think it's because java_prebuilt_impl is not adding bootclasspath to its list of
inputs.
> 
> Could you also update the template to do so so that this will be caught next
time?

I'm not sure if there is a good way to do this since the jar that is passed in
through bootclasspath is 
generated by errorprone:javac_java and the java_binary_script template where it
is used doesn't depend on that target.

So in order to list bootclasspath as an input in java_binary_script I would need
to...
(1) create a bootclasspath_dep variable and pass it down to java_binary_script
and add it to the
java_binary_script deps.
(2) set bootclasspath_dep to something hacky like 
"//third_party/errorprone:javac_java__process_jar__copy_jar"
because that is what actually lists the jar as an output.

Is there a cleaner way?

[agrieve, 2016-03-31 18:21:53]

https://codereview.chromium.org/1848593002/diff/1/third_party/errorprone/BUIL...
File third_party/errorprone/BUILD.gn (right):

https://codereview.chromium.org/1848593002/diff/1/third_party/errorprone/BUIL...
third_party/errorprone/BUILD.gn:46: bootclasspath = rebase_path(
On 2016/03/31 18:02:29, mikecase wrote:
> On 2016/03/31 at 00:22:46, agrieve wrote:
> > GN should raise errors when paths to non-existent files exist. In this case,
I
> think it's because java_prebuilt_impl is not adding bootclasspath to its list
of
> inputs.
> > 
> > Could you also update the template to do so so that this will be caught next
> time?
> 
> I'm not sure if there is a good way to do this since the jar that is passed in
> through bootclasspath is 
> generated by errorprone:javac_java and the java_binary_script template where
it
> is used doesn't depend on that target.
> 
> So in order to list bootclasspath as an input in java_binary_script I would
need
> to...
> (1) create a bootclasspath_dep variable and pass it down to java_binary_script
> and add it to the
> java_binary_script deps.
> (2) set bootclasspath_dep to something hacky like 
> "//third_party/errorprone:javac_java__process_jar__copy_jar"
> because that is what actually lists the jar as an output.
> 
> Is there a cleaner way?

The crux of the problem is in the last paragraph of the error message. Running
"gn path" is how to figure this out:

gn path . //third_party/errorprone:chromium_errorprone__java_binary_script
//third_party/errorprone:javac_java__process_jar__copy_jar
//third_party/errorprone:chromium_errorprone__java_binary_script --[private]-->
//third_party/errorprone:chromium_errorprone__build_config --[private]-->
//third_party/errorprone:javac_java --[private]-->
//third_party/errorprone:javac_java__process_jar --[public]-->
//third_party/errorprone:javac_java__process_jar__copy_jar

Showing one of 2 unique non-data paths. 0 of them are public.
Use --all to print all paths.

All of the deps need to be [public]. This is something that our android
templates have been inconsistent about, but it's the correct fix.

I've uploaded what I think the correct fix is here:
https://codereview.chromium.org/1847943003

[mikecase (-- gone --), 2016-03-31 20:47:47]

> gn path . //third_party/errorprone:chromium_errorprone__java_binary_script
//third_party/errorprone:javac_java__process_jar__copy_jar
> //third_party/errorprone:chromium_errorprone__java_binary_script
--[private]-->
> //third_party/errorprone:chromium_errorprone__build_config --[private]-->
> //third_party/errorprone:javac_java --[private]-->
> //third_party/errorprone:javac_java__process_jar --[public]-->
> //third_party/errorprone:javac_java__process_jar__copy_jar
> 
> Showing one of 2 unique non-data paths. 0 of them are public.
> Use --all to print all paths.
> 
> All of the deps need to be [public]. This is something that our android
templates have been inconsistent about, but it's the correct fix.
> 
> I've uploaded what I think the correct fix is here:
https://codereview.chromium.org/1847943003

Thanks for the info about "gn path". 
Your fix looks good and I tested it and it works. I saw you closed your review
so I copied your changes over to this CL.

[agrieve, 2016-03-31 21:11:04]

On 2016/03/31 20:47:47, mikecase wrote:
> > gn path . //third_party/errorprone:chromium_errorprone__java_binary_script
> //third_party/errorprone:javac_java__process_jar__copy_jar
> > //third_party/errorprone:chromium_errorprone__java_binary_script
> --[private]-->
> > //third_party/errorprone:chromium_errorprone__build_config --[private]-->
> > //third_party/errorprone:javac_java --[private]-->
> > //third_party/errorprone:javac_java__process_jar --[public]-->
> > //third_party/errorprone:javac_java__process_jar__copy_jar
> > 
> > Showing one of 2 unique non-data paths. 0 of them are public.
> > Use --all to print all paths.
> > 
> > All of the deps need to be [public]. This is something that our android
> templates have been inconsistent about, but it's the correct fix.
> > 
> > I've uploaded what I think the correct fix is here:
> https://codereview.chromium.org/1847943003
> 
> Thanks for the info about "gn path". 
> Your fix looks good and I tested it and it works. I saw you closed your review
> so I copied your changes over to this CL.

lgtm!

[mikecase (-- gone --), 2016-03-31 22:03:47]

The CQ bit was checked by mikecase@chromium.org

[commit-bot: I haz the power, 2016-03-31 22:04:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848593002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848593002/60001

[commit-bot: I haz the power, 2016-03-31 22:45:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-31 22:47:30]

Description was changed from

==========
Fix errorprone javac path for GN.

BUG=598708
==========

to

==========
Fix errorprone javac path for GN.

BUG=598708

Committed: https://crrev.com/0004417d4afcda9eb26321b778009357ba5ca2b5
Cr-Commit-Position: refs/heads/master@{#384423}
==========

[commit-bot: I haz the power, 2016-03-31 22:47:31]

Patchset 4 (id:??) landed as
https://crrev.com/0004417d4afcda9eb26321b778009357ba5ca2b5
Cr-Commit-Position: refs/heads/master@{#384423}