Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1848563002: Don't mix commented and uncommented generics. (Closed)

Created:
4 years, 8 months ago by nweiz
Modified:
4 years, 8 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/collection@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/wrappers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nweiz
4 years, 8 months ago (2016-03-30 19:10:35 UTC) #2
Bob Nystrom
4 years, 8 months ago (2016-03-30 19:51:50 UTC) #3
Bob Nystrom
4 years, 8 months ago (2016-03-30 19:51:51 UTC) #4
Bob Nystrom
LGTM!
4 years, 8 months ago (2016-03-30 19:51:58 UTC) #5
nweiz
4 years, 8 months ago (2016-03-30 20:34:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0603d3d10445d0963f18bfe883f404f67ad0346d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698