gypfiles/gyp_environment.py - Issue 1848553003: [gn] Move build to gypfiles

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gypfiles/gyp_environment.py

Issue 1848553003: [gn] Move build to gypfiles (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Preserve old state for the dance Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « gypfiles/get_landmines.py ('k') | gypfiles/gyp_v8 » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2015 the V8 project authors. All rights reserved.	1 # Copyright 2015 the V8 project authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 """	5 """

6 Sets up various automatic gyp environment variables. These are used by	6 Sets up various automatic gyp environment variables. These are used by

7 gyp_v8 and landmines.py which run at different stages of runhooks. To	7 gyp_v8 and landmines.py which run at different stages of runhooks. To

8 make sure settings are consistent between them, all setup should happen here.	8 make sure settings are consistent between them, all setup should happen here.

9 """	9 """

10	10

(...skipping 34 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
45	45

46	46

47 def set_environment():	47 def set_environment():

48 """Sets defaults for GYP_* variables."""	48 """Sets defaults for GYP_* variables."""

49	49

50 if 'SKIP_V8_GYP_ENV' not in os.environ:	50 if 'SKIP_V8_GYP_ENV' not in os.environ:

51 # Update the environment based on v8.gyp_env	51 # Update the environment based on v8.gyp_env

52 gyp_env_path = os.path.join(os.path.dirname(V8_ROOT), 'v8.gyp_env')	52 gyp_env_path = os.path.join(os.path.dirname(V8_ROOT), 'v8.gyp_env')

53 apply_gyp_environment(gyp_env_path)	53 apply_gyp_environment(gyp_env_path)

54 vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()	54 vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()

OLD	NEW