Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1848553002: [full-codegen] Reload context register after intrinsic call. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[full-codegen] Reload context register after intrinsic call. Previously all code stubs (i.e. both platform and Crankshaft code stubs) preserved the context register for full-codegen (neither Ignition, nor TurboFan nor Crankshaft require this or would benefit from this), but the newly introduced TurboFanCodeStubs no longer do this and there's no need to, so we have to make sure in full-codegen that we restore the context register after intrinsic calls, which potentially call TurboFanCodeStubs. Drive-by-fix: VisitThisFunction can be made platform independent. R=verwaest@chromium.org Committed: https://crrev.com/833618d91f9b65c5929bce24176899b9f63273c7 Cr-Commit-Position: refs/heads/master@{#35154}

Patch Set 1 #

Patch Set 2 : Fix missing include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -55 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 4 chunks +12 lines, -1 line 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-03-30 18:04:16 UTC) #1
Benedikt Meurer
Hey Toon, This is already required for %_ToLength, which I think somehow manages to preserve ...
4 years, 8 months ago (2016-03-30 18:05:40 UTC) #2
Toon Verwaest
lgtm, thanks for fixing this.
4 years, 8 months ago (2016-03-31 08:25:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848553002/20001
4 years, 8 months ago (2016-03-31 08:26:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 08:37:17 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 08:38:53 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/833618d91f9b65c5929bce24176899b9f63273c7
Cr-Commit-Position: refs/heads/master@{#35154}

Powered by Google App Engine
This is Rietveld 408576698