Support --persistent_worker flag in --build-mode.

Support --persistent_worker flag in --build-mode.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/6347b4cca72a31a4e5a4acdbd657b3fdc1108983

[Paul Berry, 2016-03-30 18:27:44]

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
File pkg/analyzer_cli/lib/src/build_mode.dart (right):

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/build_mode.dart:306: * Write the given [json] as a new
line to the stdout.
s/to the stdout/to the output/

(since this class is abstract and doesn't necessarily assume that the output is
going to stdout)

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/build_mode.dart:355: _writeResponse(new
WorkResponse(15, msg));
Can we make constants for these exit codes (0 above, and 15 here)?  It would
make it a lot easier to understand what's going on when reading the code.

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/build_mode.dart:450: return <String, Object>{'path':
path, 'digest': digest};
If digest is null, I'd prefer to see it not included in the JSON object.  It
makes the behavior more similar to the behavior of protobufs, which is what
we're basing this protocol on.

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/options.dart:458: 'only with the --package-mode
flag.');
s/--package-mode/--build-mode/

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/test/a...
File pkg/analyzer_cli/test/all.dart (right):

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/test/a...
pkg/analyzer_cli/test/all.dart:6: import 'build_mode_test.dart' as
build_mode_test;
Looks like you forgot to include this file.

[scheglov, 2016-03-30 18:39:02]

PTAL

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
File pkg/analyzer_cli/lib/src/build_mode.dart (right):

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/build_mode.dart:306: * Write the given [json] as a new
line to the stdout.
On 2016/03/30 18:27:43, Paul Berry wrote:
> s/to the stdout/to the output/
> 
> (since this class is abstract and doesn't necessarily assume that the output
is
> going to stdout)

Done.

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/build_mode.dart:355: _writeResponse(new
WorkResponse(15, msg));
On 2016/03/30 18:27:43, Paul Berry wrote:
> Can we make constants for these exit codes (0 above, and 15 here)?  It would
> make it a lot easier to understand what's going on when reading the code.

Done.

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/build_mode.dart:450: return <String, Object>{'path':
path, 'digest': digest};
On 2016/03/30 18:27:43, Paul Berry wrote:
> If digest is null, I'd prefer to see it not included in the JSON object.  It
> makes the behavior more similar to the behavior of protobufs, which is what
> we're basing this protocol on.

Done.

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
File pkg/analyzer_cli/lib/src/options.dart (right):

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/lib/sr...
pkg/analyzer_cli/lib/src/options.dart:458: 'only with the --package-mode
flag.');
On 2016/03/30 18:27:43, Paul Berry wrote:
> s/--package-mode/--build-mode/

Done.

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/test/a...
File pkg/analyzer_cli/test/all.dart (right):

https://codereview.chromium.org/1848543002/diff/20001/pkg/analyzer_cli/test/a...
pkg/analyzer_cli/test/all.dart:6: import 'build_mode_test.dart' as
build_mode_test;
On 2016/03/30 18:27:43, Paul Berry wrote:
> Looks like you forgot to include this file.

Done.

[Paul Berry, 2016-03-30 19:10:43]

lgtm

https://codereview.chromium.org/1848543002/diff/40001/pkg/analyzer_cli/test/b...
File pkg/analyzer_cli/test/build_mode_test.dart (right):

https://codereview.chromium.org/1848543002/diff/40001/pkg/analyzer_cli/test/b...
pkg/analyzer_cli/test/build_mode_test.dart:22: typedef
_TestWorkerLoopAnalyze(CommandLineOptions options);
Nit: return type should be void.

https://codereview.chromium.org/1848543002/diff/40001/pkg/analyzer_cli/test/b...
pkg/analyzer_cli/test/build_mode_test.dart:278: final jsonList = <Map<String,
Object>>[];
It's not immediately obvious at the usage sites whether this is meant to be a
list of inputs or outputs.  Maybe rename to `outputList`?

[scheglov, 2016-03-30 19:31:12]

Description was changed from

==========
Support --persistent_worker flag in --build-mode.

R=paulberry@google.com
BUG=
==========

to

==========
Support --persistent_worker flag in --build-mode.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/6347b4cca72a31a4e5a4acdbd657b3fdc1108983
==========

[scheglov, 2016-03-30 19:31:13]

Committed patchset #3 (id:40001) manually as
6347b4cca72a31a4e5a4acdbd657b3fdc1108983 (presubmit successful).