Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 184853012: Reland: Add ExtensionsApiClient interface, use it in the storage API SettingsFrontend (Closed)

Created:
6 years, 9 months ago by James Cook
Modified:
6 years, 9 months ago
Reviewers:
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Reland: Add ExtensionsApiClient interface, use it in the storage API SettingsFrontend app_shell needs the chrome.storage.local extension API so the core storage implementation is moving to //extensions/browser/api. However, the "managed storage" API implementation needs to remain in Chrome. * Introduce ExtensionsApiClient in extensions/browser/api * Introduce ChromeExtensionsApiClient in chrome/browser/extensions/api * Delegate out the storage ManagedValueStoreCache creation to Chrome * Move settings_namespace.h/cc to e/b/api/storage so we can use an enum in the client interface definition Most APIs will probably need to make only one or two client interface calls, so we're starting with a single ExtensionsApiClient interface. It we find individual APIs tend to need a lot of methods we can split it into one client interface per API, but that seems like overkill right now. Reland of https://codereview.chromium.org/180213008/ with fixes for Android GCMProfileServiceSingleProfileTest.Unregister BUG=348058 TEST=unit_tests *Settings* and browser_tests ExtensionSettings* TBR=rdevlin.cronin@chromium.org, rockot@chromium.org, yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255384

Patch Set 1 : original patch #

Patch Set 2 : ChromeExtensionsAPIClient for Android #

Patch Set 3 : rebase (api_client) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -111 lines) Patch
M apps/shell/browser/shell_extensions_browser_client.h View 2 chunks +5 lines, -0 lines 0 comments Download
M apps/shell/browser/shell_extensions_browser_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/chrome_extensions_api_client.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/storage/policy_value_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_backend.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/storage/settings_namespace.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_namespace.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_sync_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/settings_test_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/storage_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/storage/syncable_settings_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 3 chunks +4 lines, -2 lines 0 comments Download
A extensions/browser/api/extensions_api_client.h View 1 chunk +56 lines, -0 lines 0 comments Download
A extensions/browser/api/extensions_api_client.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A + extensions/browser/api/storage/settings_namespace.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/storage/settings_namespace.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-05 23:53:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/184853012/30026
6 years, 9 months ago (2014-03-06 00:26:10 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 01:20:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275871
6 years, 9 months ago (2014-03-06 01:20:27 UTC) #4
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-06 02:57:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/184853012/30026
6 years, 9 months ago (2014-03-06 03:07:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 06:35:40 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=276116
6 years, 9 months ago (2014-03-06 06:35:41 UTC) #8
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 9 months ago (2014-03-06 16:32:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/184853012/30026
6 years, 9 months ago (2014-03-06 16:33:38 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 17:36:56 UTC) #11
Message was sent while issue was closed.
Change committed as 255384

Powered by Google App Engine
This is Rietveld 408576698