Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 184853007: remove -d from adb install since it does not seem to be supported anymore (Closed)

Created:
6 years, 9 months ago by Miguel Garcia
Modified:
6 years, 9 months ago
Reviewers:
bulach, ian_cottrell
CC:
chromium-reviews
Visibility:
Public.

Description

remove -d from adb install since it does not seem to be supported anymore BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/cr/cr/actions/adb.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
Miguel Garcia
6 years, 9 months ago (2014-03-06 12:19:47 UTC) #1
Miguel Garcia
On 2014/03/06 12:19:47, Miguel Garcia wrote: Friendly ping
6 years, 9 months ago (2014-03-07 10:00:32 UTC) #2
ian_cottrell
On 2014/03/07 10:00:32, Miguel Garcia wrote: > On 2014/03/06 12:19:47, Miguel Garcia wrote: > > ...
6 years, 9 months ago (2014-03-07 10:02:15 UTC) #3
Miguel Garcia
The CQ bit was checked by miguelg@chromium.org
6 years, 9 months ago (2014-03-07 10:07:39 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 10:08:54 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-07 10:08:55 UTC) #6
Miguel Garcia
lgtm
6 years, 9 months ago (2014-03-07 10:10:41 UTC) #7
Miguel Garcia
The CQ bit was checked by miguelg@chromium.org
6 years, 9 months ago (2014-03-07 10:10:47 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 10:10:52 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 9 months ago (2014-03-07 10:10:52 UTC) #10
Miguel Garcia
Marcus, sorry to drag you to this. Do you mind LGTMing I need an LGTM ...
6 years, 9 months ago (2014-03-07 11:16:02 UTC) #11
bulach
lgtm, thanks!
6 years, 9 months ago (2014-03-07 11:38:29 UTC) #12
Miguel Garcia
The CQ bit was checked by miguelg@chromium.org
6 years, 9 months ago (2014-03-07 11:58:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/184853007/1
6 years, 9 months ago (2014-03-07 12:00:01 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-07 12:09:23 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg
6 years, 9 months ago (2014-03-07 12:09:24 UTC) #16
Miguel Garcia
The CQ bit was checked by miguelg@chromium.org
6 years, 9 months ago (2014-03-07 12:18:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miguelg@chromium.org/184853007/1
6 years, 9 months ago (2014-03-07 12:19:38 UTC) #18
commit-bot: I haz the power
6 years, 9 months ago (2014-03-07 15:13:48 UTC) #19
Message was sent while issue was closed.
Change committed as 255616

Powered by Google App Engine
This is Rietveld 408576698