Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8057)

Unified Diff: chrome/common/extensions/api/cast_streaming_rtp_stream.idl

Issue 184853003: Cast: Add GetStats() extensions API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add missing include Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/cast_streaming_rtp_stream.idl
diff --git a/chrome/common/extensions/api/cast_streaming_rtp_stream.idl b/chrome/common/extensions/api/cast_streaming_rtp_stream.idl
index e0e3e8016389c91805241e66ba6ed30fee5ac565..e8de8a5cac18f38ef06c732e1b76332f32177ec4 100644
--- a/chrome/common/extensions/api/cast_streaming_rtp_stream.idl
+++ b/chrome/common/extensions/api/cast_streaming_rtp_stream.idl
@@ -65,13 +65,13 @@ namespace cast.streaming.rtpStream {
// a stream.
not at google - send to devlin 2014/03/05 20:27:10 this comment needs updating
imcheng 2014/03/05 20:36:00 I changed the return type back to DOMString. But I
// The serialization format can be found at
// media/cast/logging/log_serializer.cc.
- callback GetRawEventsCallback = void (DOMString rawEvents);
+ callback GetRawEventsCallback = void (object rawEvents);
// Callback from the <code>getStats</code> method.
- // |rawEvents|: serialized raw bytes containing stats recorded for a stream.
- // The serialization format can be found at
- // media/cast/logging/log_serializer.cc.
- callback GetStatsCallback = void (DOMString stats);
+ // |rawEvents|: dictionary object containing stats recorded for a stream.
+ // The format can be found at
+ // media/cast/logging/stats_converter.cc.
+ callback GetStatsCallback = void (object stats);
interface Functions {
// Destroys a Cast RTP stream.
@@ -99,13 +99,13 @@ namespace cast.streaming.rtpStream {
// Get raw events for a stream in the current session.
// |streamId|: Stream to get events for.
- // |callback|: Called with the raw events Blob.
+ // |callback|: Called with the raw events.
[nocompile] static void getRawEvents(
long streamId, GetRawEventsCallback callback);
// Get stats for a stream in the current session.
// |streamId|: Stream to get stats for.
- // |callback|: Called with the stats Blob.
+ // |callback|: Called with the stats.
[nocompile] static void getStats(
long streamId, GetStatsCallback callback);
};
« no previous file with comments | « chrome/browser/extensions/cast_streaming_apitest.cc ('k') | chrome/renderer/extensions/cast_streaming_native_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698