Cast: Add GetStats() extensions API.

media/cast/logging/logging_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef MEDIA_CAST_LOGGING_LOGGING_IMPL_H_
 #define MEDIA_CAST_LOGGING_LOGGING_IMPL_H_
 
 // Generic class that handles event logging for the cast library.
 // Logging has three possible optional forms:
 // 1. Raw data and stats accessible by the application.
 // 2. Tracing of raw events.
@@ skipping 40 matching lines @@
                           CastLoggingEvent event, int value);
 
 
   // Delegates to |LoggingRaw::AddRawEventSubscriber()|.
   void AddRawEventSubscriber(RawEventSubscriber* subscriber);
 
   // Delegates to |LoggingRaw::RemoveRawEventSubscriber()|.
   void RemoveRawEventSubscriber(RawEventSubscriber* subscriber);
 
   // Get stats only.
-  FrameStatsMap GetFrameStatsData() const;
-  PacketStatsMap GetPacketStatsData() const;
+  FrameStatsMap GetFrameStatsData(EventMediaType media_type) const;

[Alpha Left Google, 2014/03/03 07:11:39]

Have you considered having seprate stats object for audio and video?

[imcheng, 2014/03/04 02:06:24]

Yes, the plan is have stats collection be a RawEventSubscriber implementation.
In LoggingImpl, if stats collection is enabled, then install separate
StatsSubscriber objects for video and audio events. But that's for a later CL.
In this CL I just want to get the JS API working without making too much
changes.

+  PacketStatsMap GetPacketStatsData(EventMediaType media_type) const;
   GenericStatsMap GetGenericStatsData() const;
 
   // Reset stats logging data.
   void ResetStats();
 
  private:
   scoped_refptr<base::SingleThreadTaskRunner> main_thread_proxy_;
   const CastLoggingConfig config_;
   LoggingRaw raw_;
   LoggingStats stats_;

[Alpha Left Google, 2014/03/03 07:11:39]

Maybe a separate LoggingStats object for audio and video?

[imcheng, 2014/03/04 02:06:24]

See above.

 
   DISALLOW_COPY_AND_ASSIGN(LoggingImpl);
 };
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_LOGGING_LOGGING_IMPL_H_