Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1848523003: Consolidate ShadowRootDelegatesFocus experimental flag (Closed)

Created:
4 years, 8 months ago by kochi
Modified:
4 years, 8 months ago
Reviewers:
tkent, hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, kinuko+watch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate ShadowRootDelegatesFocus experimental flag As it depends on Shadow DOM v1 launch, merge the flag into ShadowDOMV1 flag. BUG=531990 Committed: https://crrev.com/d5329ca825cec17a8b99e25c6f0c77048a4b09c2 Cr-Commit-Position: refs/heads/master@{#384233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRootInit.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
kochi
PTAL
4 years, 8 months ago (2016-03-31 08:20:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848523003/1
4 years, 8 months ago (2016-03-31 08:20:31 UTC) #4
hayato
lgtm
4 years, 8 months ago (2016-03-31 08:22:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848523003/1
4 years, 8 months ago (2016-03-31 08:39:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/162482)
4 years, 8 months ago (2016-03-31 08:48:44 UTC) #10
kochi
tkent-san could you review for RuntimeEnabledFeatures.in?
4 years, 8 months ago (2016-03-31 08:51:24 UTC) #13
tkent
lgtm
4 years, 8 months ago (2016-03-31 08:53:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848523003/1
4 years, 8 months ago (2016-03-31 08:53:40 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 09:39:54 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 09:41:10 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5329ca825cec17a8b99e25c6f0c77048a4b09c2
Cr-Commit-Position: refs/heads/master@{#384233}

Powered by Google App Engine
This is Rietveld 408576698