Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: base/feature_list.h

Issue 1848523002: Changes to support using base/feature_list.h from gin/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gin/isolate_holder.cc changes (sample feature) reverted. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/feature_list.cc » ('j') | base/test/test_suite.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/feature_list.h
diff --git a/base/feature_list.h b/base/feature_list.h
index c4d6e83f0f925ff7e46cb72e7d37259e20602189..12fb3450d3e57627a146e37e0f18610167b6de38 100644
--- a/base/feature_list.h
+++ b/base/feature_list.h
@@ -147,10 +147,10 @@ class BASE_EXPORT FeatureList {
// Initializes and sets an instance of FeatureList with feature overrides via
// command-line flags |enable_features| and |disable_features| if one has not
- // already been set from command-line flags. No-op otherwise. See
- // InitializeFromCommandLine for more details about |enable_features| and
- // |disable_features| parameters.
- static void InitializeInstance(const std::string& enable_features,
+ // already been set from command-line flags. Returns true if an instance did
+ // not previously exist. See InitializeFromCommandLine() for more details
+ // about |enable_features| and |disable_features| parameters.
+ static bool InitializeInstance(const std::string& enable_features,
const std::string& disable_features);
// Returns the singleton instance of FeatureList. Will return null until an
« no previous file with comments | « no previous file | base/feature_list.cc » ('j') | base/test/test_suite.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698