Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1848513003: Switch Android Asan Builder Tests on chromium.fyi to chromium recipe. (Closed)

Created:
4 years, 8 months ago by bpastene
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Switch Android Asan Builder Tests on chromium.fyi to chromium recipe. Src-side tests here: https://codereview.chromium.org/1849493002/ Added mb configs here: https://codereview.chromium.org/1830423002 BUG=598907 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299578

Patch Set 1 #

Patch Set 2 : Change to asan config and add instrumentation tests build-side. #

Total comments: 4

Patch Set 3 : Spaces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -115 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 2 1 chunk +29 lines, -2 lines 0 comments Download
A + scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Asan_Builder_Tests__dbg_.json View 1 15 chunks +179 lines, -112 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bpastene
ptal https://codereview.chromium.org/1848513003/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right): https://codereview.chromium.org/1848513003/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py#newcode2008 scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2008: steps.AndroidInstrumentationTest('AndroidWebViewTest', tool='asan'), There's no support for adding 'tool' ...
4 years, 8 months ago (2016-03-30 18:43:51 UTC) #3
jbudorick
lgtm w/ nits https://codereview.chromium.org/1848513003/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right): https://codereview.chromium.org/1848513003/diff/20001/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py#newcode2008 scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2008: steps.AndroidInstrumentationTest('AndroidWebViewTest', tool='asan'), On 2016/03/30 18:43:51, bpastene ...
4 years, 8 months ago (2016-03-30 19:23:34 UTC) #4
bpastene
adding sergeyberezin@ for chromium_tests owners
4 years, 8 months ago (2016-03-30 23:37:05 UTC) #6
Sergey Berezin
lgtm
4 years, 8 months ago (2016-03-31 00:40:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848513003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848513003/40001
4 years, 8 months ago (2016-03-31 01:16:48 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 01:20:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299578

Powered by Google App Engine
This is Rietveld 408576698