Issue 18485004: fix swapped bitmap channels on Mac for debugger

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18485004: fix swapped bitmap channels on Mac for debugger (Closed)

Created:
7 years, 5 months ago by humper

Modified:
7 years, 5 months ago

Reviewers:
djsollen, mtklein, bsalomon, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

fix swapped bitmap channels on Mac for debugger BUG= R=djsollen@google.com, robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9958

Patch Set 2 : remove leftover iostream #

Patch Set 3 : style fix #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	debugger/QT/SkRasterWidget.cpp	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 1 question. https://codereview.chromium.org/18485004/diff/1/debugger/QT/SkRasterWidget.cpp File debugger/QT/SkRasterWidget.cpp (right): https://codereview.chromium.org/18485004/diff/1/debugger/QT/SkRasterWidget.cpp#newcode9 debugger/QT/SkRasterWidget.cpp:9: #include <iostream> Do we need ...

7 years, 5 months ago (2013-07-10 15:50:04 UTC) #2

humper

On 2013/07/10 15:50:04, robertphillips wrote: > lgtm + 1 question. > > https://codereview.chromium.org/18485004/diff/1/debugger/QT/SkRasterWidget.cpp > File ...

7 years, 5 months ago (2013-07-10 15:51:44 UTC) #3