Revert of Print with the correct physical dimensions when specified (patchset #10 id:180001 of https://codereview.chromium.org/1817873002/ )
Reason for revert:
Causing failures on Webkit Win10: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190
unexpected_failures:
printing/quirks-percentage-height-body.html
virtual/threaded/printing/standards-percentage-heights.html
virtual/threaded/printing/subframes-percentage-height.html
virtual/threaded/printing/quirks-percentage-height.html
printing/standards-percentage-heights.html
printing/quirks-percentage-height.html
virtual/threaded/printing/quirks-percentage-height-body.html
printing/subframes-percentage-height.html
Original issue's description:
> Print with the correct physical dimensions when specified
>
> If you specify a div in cm, mm or a similar unit of physical measurement and
> print it you don't get an element of the expected size on paper. This is due
> to the scaling factor we use when resizing the page for printing.
>
> The scaling factor of 1.25 was introduced by https://trac.webkit.org/changeset/22945
> and adopted in the Gtk port by http://wkbug.com/15576. It seems to
> be a magic number that was 'about right'. From trial and error 1.33 seems to be
> the magic number that produces output with the correct physical size.
>
> I don't know how to test this.
>
> BUG=273306
>
> Committed: https://crrev.com/b0b70b1a7023b375e31b94799e109fd1c19005c0
> Cr-Commit-Position: refs/heads/master@{#383925}
TBR=alekseys@chromium.org,eae@chromium.org,gene@chromium.org,thestig@chromium.org,pdr@chromium.org,thakis@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=273306
Committed: https://crrev.com/a052b2656a69f04c29b8e9379c73258384401eca
Cr-Commit-Position: refs/heads/master@{#384129}
Created Revert of Print with the correct physical dimensions when specified
4 years, 8 months ago
(2016-03-30 22:40:15 UTC)
#1
Created Revert of Print with the correct physical dimensions when specified
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848443003/1
4 years, 8 months ago
(2016-03-30 22:40:44 UTC)
#2
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848443003/290001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848443003/290001
4 years, 8 months ago
(2016-03-30 22:59:38 UTC)
#6
Description was changed from ========== Revert of Print with the correct physical dimensions when specified ...
4 years, 8 months ago
(2016-03-30 23:00:28 UTC)
#7
Message was sent while issue was closed.
Description was changed from
==========
Revert of Print with the correct physical dimensions when specified (patchset
#10 id:180001 of https://codereview.chromium.org/1817873002/ )
Reason for revert:
Causing failures on Webkit Win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190
unexpected_failures:
printing/quirks-percentage-height-body.html
virtual/threaded/printing/standards-percentage-heights.html
virtual/threaded/printing/subframes-percentage-height.html
virtual/threaded/printing/quirks-percentage-height.html
printing/standards-percentage-heights.html
printing/quirks-percentage-height.html
virtual/threaded/printing/quirks-percentage-height-body.html
printing/subframes-percentage-height.html
Original issue's description:
> Print with the correct physical dimensions when specified
>
> If you specify a div in cm, mm or a similar unit of physical measurement and
> print it you don't get an element of the expected size on paper. This is due
> to the scaling factor we use when resizing the page for printing.
>
> The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
> and adopted in the Gtk port by http://wkbug.com/15576. It seems to
> be a magic number that was 'about right'. From trial and error 1.33 seems to
be
> the magic number that produces output with the correct physical size.
>
> I don't know how to test this.
>
> BUG=273306
>
> Committed: https://crrev.com/b0b70b1a7023b375e31b94799e109fd1c19005c0
> Cr-Commit-Position: refs/heads/master@{#383925}
TBR=alekseys@chromium.org,eae@chromium.org,gene@chromium.org,thestig@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=273306
==========
to
==========
Revert of Print with the correct physical dimensions when specified (patchset
#10 id:180001 of https://codereview.chromium.org/1817873002/ )
Reason for revert:
Causing failures on Webkit Win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190
unexpected_failures:
printing/quirks-percentage-height-body.html
virtual/threaded/printing/standards-percentage-heights.html
virtual/threaded/printing/subframes-percentage-height.html
virtual/threaded/printing/quirks-percentage-height.html
printing/standards-percentage-heights.html
printing/quirks-percentage-height.html
virtual/threaded/printing/quirks-percentage-height-body.html
printing/subframes-percentage-height.html
Original issue's description:
> Print with the correct physical dimensions when specified
>
> If you specify a div in cm, mm or a similar unit of physical measurement and
> print it you don't get an element of the expected size on paper. This is due
> to the scaling factor we use when resizing the page for printing.
>
> The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
> and adopted in the Gtk port by http://wkbug.com/15576. It seems to
> be a magic number that was 'about right'. From trial and error 1.33 seems to
be
> the magic number that produces output with the correct physical size.
>
> I don't know how to test this.
>
> BUG=273306
>
> Committed: https://crrev.com/b0b70b1a7023b375e31b94799e109fd1c19005c0
> Cr-Commit-Position: refs/heads/master@{#383925}
TBR=alekseys@chromium.org,eae@chromium.org,gene@chromium.org,thestig@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=273306
==========
commit-bot: I haz the power
Committed patchset #2 (id:290001)
4 years, 8 months ago
(2016-03-30 23:00:29 UTC)
#8
Message was sent while issue was closed.
Committed patchset #2 (id:290001)
commit-bot: I haz the power
Description was changed from ========== Revert of Print with the correct physical dimensions when specified ...
4 years, 8 months ago
(2016-03-30 23:01:30 UTC)
#9
Message was sent while issue was closed.
Description was changed from
==========
Revert of Print with the correct physical dimensions when specified (patchset
#10 id:180001 of https://codereview.chromium.org/1817873002/ )
Reason for revert:
Causing failures on Webkit Win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190
unexpected_failures:
printing/quirks-percentage-height-body.html
virtual/threaded/printing/standards-percentage-heights.html
virtual/threaded/printing/subframes-percentage-height.html
virtual/threaded/printing/quirks-percentage-height.html
printing/standards-percentage-heights.html
printing/quirks-percentage-height.html
virtual/threaded/printing/quirks-percentage-height-body.html
printing/subframes-percentage-height.html
Original issue's description:
> Print with the correct physical dimensions when specified
>
> If you specify a div in cm, mm or a similar unit of physical measurement and
> print it you don't get an element of the expected size on paper. This is due
> to the scaling factor we use when resizing the page for printing.
>
> The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
> and adopted in the Gtk port by http://wkbug.com/15576. It seems to
> be a magic number that was 'about right'. From trial and error 1.33 seems to
be
> the magic number that produces output with the correct physical size.
>
> I don't know how to test this.
>
> BUG=273306
>
> Committed: https://crrev.com/b0b70b1a7023b375e31b94799e109fd1c19005c0
> Cr-Commit-Position: refs/heads/master@{#383925}
TBR=alekseys@chromium.org,eae@chromium.org,gene@chromium.org,thestig@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=273306
==========
to
==========
Revert of Print with the correct physical dimensions when specified (patchset
#10 id:180001 of https://codereview.chromium.org/1817873002/ )
Reason for revert:
Causing failures on Webkit Win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190
unexpected_failures:
printing/quirks-percentage-height-body.html
virtual/threaded/printing/standards-percentage-heights.html
virtual/threaded/printing/subframes-percentage-height.html
virtual/threaded/printing/quirks-percentage-height.html
printing/standards-percentage-heights.html
printing/quirks-percentage-height.html
virtual/threaded/printing/quirks-percentage-height-body.html
printing/subframes-percentage-height.html
Original issue's description:
> Print with the correct physical dimensions when specified
>
> If you specify a div in cm, mm or a similar unit of physical measurement and
> print it you don't get an element of the expected size on paper. This is due
> to the scaling factor we use when resizing the page for printing.
>
> The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
> and adopted in the Gtk port by http://wkbug.com/15576. It seems to
> be a magic number that was 'about right'. From trial and error 1.33 seems to
be
> the magic number that produces output with the correct physical size.
>
> I don't know how to test this.
>
> BUG=273306
>
> Committed: https://crrev.com/b0b70b1a7023b375e31b94799e109fd1c19005c0
> Cr-Commit-Position: refs/heads/master@{#383925}
TBR=alekseys@chromium.org,eae@chromium.org,gene@chromium.org,thestig@chromium...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=273306
Committed: https://crrev.com/a052b2656a69f04c29b8e9379c73258384401eca
Cr-Commit-Position: refs/heads/master@{#384129}
==========
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a052b2656a69f04c29b8e9379c73258384401eca Cr-Commit-Position: refs/heads/master@{#384129}
4 years, 8 months ago
(2016-03-30 23:01:32 UTC)
#10
Issue 1848443003: Revert of Print with the correct physical dimensions when specified
(Closed)
Created 4 years, 8 months ago by Devlin
Modified 4 years, 8 months ago
Reviewers: Aleksey Shlyapnikov, eae, gene, Lei Zhang, pdr., Nico, rhogan
Base URL: https://chromium.googlesource.com/chromium/src.git@262769
Comments: 0