Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1848443003: Revert of Print with the correct physical dimensions when specified (Closed)

Created:
4 years, 8 months ago by Devlin
Modified:
4 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@262769
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Print with the correct physical dimensions when specified (patchset #10 id:180001 of https://codereview.chromium.org/1817873002/ ) Reason for revert: Causing failures on Webkit Win10: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190 unexpected_failures: printing/quirks-percentage-height-body.html virtual/threaded/printing/standards-percentage-heights.html virtual/threaded/printing/subframes-percentage-height.html virtual/threaded/printing/quirks-percentage-height.html printing/standards-percentage-heights.html printing/quirks-percentage-height.html virtual/threaded/printing/quirks-percentage-height-body.html printing/subframes-percentage-height.html Original issue's description: > Print with the correct physical dimensions when specified > > If you specify a div in cm, mm or a similar unit of physical measurement and > print it you don't get an element of the expected size on paper. This is due > to the scaling factor we use when resizing the page for printing. > > The scaling factor of 1.25 was introduced by https://trac.webkit.org/changeset/22945 > and adopted in the Gtk port by http://wkbug.com/15576. It seems to > be a magic number that was 'about right'. From trial and error 1.33 seems to be > the magic number that produces output with the correct physical size. > > I don't know how to test this. > > BUG=273306 > > Committed: https://crrev.com/b0b70b1a7023b375e31b94799e109fd1c19005c0 > Cr-Commit-Position: refs/heads/master@{#383925} TBR=alekseys@chromium.org,eae@chromium.org,gene@chromium.org,thestig@chromium.org,pdr@chromium.org,thakis@chromium.org,robhogan@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=273306 Committed: https://crrev.com/a052b2656a69f04c29b8e9379c73258384401eca Cr-Commit-Position: refs/heads/master@{#384129}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -100 lines) Patch
M components/printing/renderer/print_web_view_helper.cc View 1 3 chunks +7 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squashing-print-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/squashing-print-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/ellipsis-printing-style-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/forced-break-tree-dump-only-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/iframe-print-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/iframe-print-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/printing/page-count-relayout-shrink-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/quirks-percentage-height-body-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/quirks-percentage-height-body-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/quirks-percentage-height-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/quirks-percentage-height-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/standards-percentage-heights-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/standards-percentage-heights-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/subframes-percentage-height-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/printing/subframes-percentage-height-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/ellipsis-printing-style-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/iframe-print-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/ellipsis-printing-style-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/printing/ellipsis-printing-style-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/printing/quirks-percentage-height-body-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/printing/quirks-percentage-height-expected.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/printing/resources/paged-media-test-utils.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/printing/simultaneous-position-float-change-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
A + third_party/WebKit/LayoutTests/printing/standards-percentage-heights-expected.html View 1 1 chunk +2 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/printing/subframes-percentage-height-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/PrintContext.cpp View 1 2 chunks +7 lines, -10 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Devlin
Created Revert of Print with the correct physical dimensions when specified
4 years, 8 months ago (2016-03-30 22:40:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848443003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848443003/1
4 years, 8 months ago (2016-03-30 22:40:44 UTC) #2
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
4 years, 8 months ago (2016-03-30 22:41:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848443003/290001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848443003/290001
4 years, 8 months ago (2016-03-30 22:59:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:290001)
4 years, 8 months ago (2016-03-30 23:00:29 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 23:01:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a052b2656a69f04c29b8e9379c73258384401eca
Cr-Commit-Position: refs/heads/master@{#384129}

Powered by Google App Engine
This is Rietveld 408576698