Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: ios/chrome/browser/passwords/password_controller.h

Issue 1848433004: Reland of Add a unittest for PasswordController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/BUILD.gn ('k') | ios/chrome/browser/passwords/password_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/passwords/password_controller.h
diff --git a/ios/chrome/browser/passwords/password_controller.h b/ios/chrome/browser/passwords/password_controller.h
index 498481fb14232df9809b2f19d04f95e08fa59326..f74a84503837557f78a4a68aafa7ab797b51769b 100644
--- a/ios/chrome/browser/passwords/password_controller.h
+++ b/ios/chrome/browser/passwords/password_controller.h
@@ -9,6 +9,7 @@
#import "ios/chrome/browser/autofill/form_suggestion_provider.h"
#import "ios/chrome/browser/passwords/ios_chrome_password_manager_client.h"
#import "ios/chrome/browser/passwords/ios_chrome_password_manager_driver.h"
+#import "ios/web/public/web_state/web_state_observer_bridge.h"
@protocol FormInputAccessoryViewProvider;
@protocol PasswordsUiDelegate;
@@ -22,8 +23,9 @@ class PasswordManagerDriver;
} // namespace password_manager
// Per-tab password controller. Handles password autofill and saving.
-@interface PasswordController
- : NSObject<PasswordManagerClientDelegate, PasswordManagerDriverDelegate>
+@interface PasswordController : NSObject<CRWWebStateObserver,
+ PasswordManagerClientDelegate,
+ PasswordManagerDriverDelegate>
// An object that can provide suggestions from this PasswordController.
@property(readonly) id<FormSuggestionProvider> suggestionProvider;
@@ -46,8 +48,14 @@ class PasswordManagerDriver;
// |webState| should not be nil.
- (instancetype)initWithWebState:(web::WebState*)webState
- passwordsUiDelegate:(id<PasswordsUiDelegate>)UIDelegate
- NS_DESIGNATED_INITIALIZER;
+ passwordsUiDelegate:(id<PasswordsUiDelegate>)UIDelegate;
+
+// This is just for testing.
+- (instancetype)
+ initWithWebState:(web::WebState*)webState
+passwordsUiDelegate:(id<PasswordsUiDelegate>)UIDelegate
+ client:(scoped_ptr<password_manager::PasswordManagerClient>)
+ passwordManagerClient NS_DESIGNATED_INITIALIZER;
- (instancetype)init NS_UNAVAILABLE;
« no previous file with comments | « ios/chrome/BUILD.gn ('k') | ios/chrome/browser/passwords/password_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698