Reland of Add a unittest for PasswordController

Reland of Add a unittest for PasswordController

Original CL: https://codereview.chromium.org/1808853005/
CL with revert: https://codereview.chromium.org/1842313002/
Patch set 1 here == what landed in the original CL
Subsequent patches constitute the fix of the breakage.
TBR-ing droger@ for the GYP and GN changes, which he already approved in the
original CL, and which are not different here.

Original description:
-------------
While PasswordController already has a unittest downstream, that one is rather
an integration test (the heaviness of which is the reason it is still
downstream, stuck on some downstream-only testing framework).

When a test was needed for https://codereview.chromium.org/1806333005/, it
turned out a simple unittest would be better. This CL adds that test and
places it upstream. (Ultimately we should convert the downstream tests to a
lighter version and add them here as well, but not in this CL.)
-------------

BUG=595717, 598672, 599231
TBR=droger@chromium.org

Committed: https://crrev.com/40a58addf1b656beaac8b7a2f50cca718a0556e0
Cr-Commit-Position: refs/heads/master@{#384291}

[vabr (Chromium), 2016-03-31 11:23:52]

vabr@chromium.org changed reviewers:
+ dvadym@chromium.org

[vabr (Chromium), 2016-03-31 11:23:53]

(TBR-in droger for GN & GYP, because those did not change since the original CL,
which he approved.)

Vadym,

Could you please have a look at the diff of patch set 2 against patch set 1?
Everything else is the old CL, which was already reviewed by you.

To ensure that I'm not breaking the iOS build again, I ran downstream tests
locally and also on downstream trybots. The tests passed.

Cheers,
Vaclav

[vabr (Chromium), 2016-03-31 13:44:31]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 13:44:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848433004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848433004/20001

[commit-bot: I haz the power, 2016-03-31 13:53:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 13:53:46]

Dry run: This issue passed the CQ dry run.

[dvadym, 2016-03-31 14:42:45]

LGTM

[vabr (Chromium), 2016-03-31 15:47:59]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2016-03-31 15:48:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1848433004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1848433004/20001

[commit-bot: I haz the power, 2016-03-31 15:54:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 15:56:20]

Description was changed from

==========
Reland of Add a unittest for PasswordController

Original CL: https://codereview.chromium.org/1808853005/
CL with revert: https://codereview.chromium.org/1842313002/
Patch set 1 here == what landed in the original CL
Subsequent patches constitute the fix of the breakage.
TBR-ing droger@ for the GYP and GN changes, which he already approved in the
original CL, and which are not different here.

Original description:
-------------
While PasswordController already has a unittest downstream, that one is rather
an integration test (the heaviness of which is the reason it is still
downstream, stuck on some downstream-only testing framework).

When a test was needed for https://codereview.chromium.org/1806333005/, it
turned out a simple unittest would be better. This CL adds that test and
places it upstream. (Ultimately we should convert the downstream tests to a
lighter version and add them here as well, but not in this CL.)
-------------

BUG=595717, 598672, 599231
TBR=droger@chromium.org
==========

to

==========
Reland of Add a unittest for PasswordController

Original CL: https://codereview.chromium.org/1808853005/
CL with revert: https://codereview.chromium.org/1842313002/
Patch set 1 here == what landed in the original CL
Subsequent patches constitute the fix of the breakage.
TBR-ing droger@ for the GYP and GN changes, which he already approved in the
original CL, and which are not different here.

Original description:
-------------
While PasswordController already has a unittest downstream, that one is rather
an integration test (the heaviness of which is the reason it is still
downstream, stuck on some downstream-only testing framework).

When a test was needed for https://codereview.chromium.org/1806333005/, it
turned out a simple unittest would be better. This CL adds that test and
places it upstream. (Ultimately we should convert the downstream tests to a
lighter version and add them here as well, but not in this CL.)
-------------

BUG=595717, 598672, 599231
TBR=droger@chromium.org

Committed: https://crrev.com/40a58addf1b656beaac8b7a2f50cca718a0556e0
Cr-Commit-Position: refs/heads/master@{#384291}
==========

[commit-bot: I haz the power, 2016-03-31 15:56:21]

Patchset 2 (id:??) landed as
https://crrev.com/40a58addf1b656beaac8b7a2f50cca718a0556e0
Cr-Commit-Position: refs/heads/master@{#384291}