Issue 184843004: Remove blank password UMA collection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 184843004: Remove blank password UMA collection (Closed)

Created:
6 years, 9 months ago by cpu_(ooo_6.6-7.5)

Modified:
6 years, 9 months ago

Reviewers:
jam, Will Harris

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove blank password UMA collection This seems to cause some XP machines and Vista machines with blank passwords to not work at all. This is because we call GetOsPasswordStatus() 10 seconds after a webcontents is created. TBR=jam BUG=345916 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254280

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -19 lines)			Patch
	M	chrome/browser/password_manager/chrome_password_manager_client.cc	View		2 chunks	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/184843004/1

6 years, 9 months ago (2014-02-28 22:05:14 UTC) #2

Message was sent while issue was closed.

Change committed as 254280

Expand Messages | Collapse Messages