Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1848413002: [Chromecast] Run ipc_tests with only one test launcher job. (Closed)

Created:
4 years, 8 months ago by slan
Modified:
4 years, 8 months ago
Reviewers:
halliwell, mbjorge
CC:
chromium-reviews, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Run ipc_tests with only one test launcher job. It seems that running tests in parallel is causing a race condition, where a unix socket is destroyed in one process, then accessed in another. Revert this change when we can root-cause the regression. BUG= internal b/27963186 Committed: https://crrev.com/6ab3cfc657196999716cada178f5c9fba837051d Cr-Commit-Position: refs/heads/master@{#384721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chromecast/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
slan
4 years, 8 months ago (2016-04-01 21:41:16 UTC) #2
slan
4 years, 8 months ago (2016-04-01 21:41:27 UTC) #4
halliwell
On 2016/04/01 21:41:27, slan wrote: lgtm % nit, fix the BUG=syntax are we filing a ...
4 years, 8 months ago (2016-04-01 21:51:43 UTC) #5
slan
On 2016/04/01 21:51:43, halliwell wrote: > On 2016/04/01 21:41:27, slan wrote: > > lgtm % ...
4 years, 8 months ago (2016-04-01 21:53:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848413002/1
4 years, 8 months ago (2016-04-01 21:53:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 23:48:43 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 23:49:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ab3cfc657196999716cada178f5c9fba837051d
Cr-Commit-Position: refs/heads/master@{#384721}

Powered by Google App Engine
This is Rietveld 408576698