Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1848383002: SkPDF: properly dedup bitmaps in shaders (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2016-04-01 (Friday) 14:34:50 EDT #

Patch Set 3 : 2016-04-01 (Friday) 14:35:15 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -6 lines) Patch
A gm/subsetshader.cpp View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M src/pdf/SkBitmapKey.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848383002/40001
4 years, 8 months ago (2016-04-01 18:36:04 UTC) #4
hal.canary
ptal
4 years, 8 months ago (2016-04-01 18:37:07 UTC) #6
tomhudson
lgtm
4 years, 8 months ago (2016-04-01 18:42:22 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 18:46:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848383002/40001
4 years, 8 months ago (2016-04-01 18:50:04 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 18:51:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/895f3f0544ce38d35999771754cbb1d876c14b5a

Powered by Google App Engine
This is Rietveld 408576698