Issue 1848353003: Make msys depot_tools upgrade process smoother.

Issue 1848353003: Make msys depot_tools upgrade process smoother. (Closed)

Created:
4 years, 8 months ago by iannucci

Modified:
4 years, 8 months ago

Reviewers:
dnj, agable, Michael Moss

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

Make msys depot_tools upgrade process smoother. R=agable@chromium.org, dnj@chromium.org, mmoss@chromium.org BUG=600028 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299677

Patch Set 2 : add comment #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -4 lines)			Patch
M	bootstrap/win/win_tools.bat	View	1	5 chunks	+17 lines, -4 lines	0 comments	Download
M	gclient	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	update_depot_tools	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

dnj

lgtm https://codereview.chromium.org/1848353003/diff/1/bootstrap/win/win_tools.bat File bootstrap/win/win_tools.bat (right): https://codereview.chromium.org/1848353003/diff/1/bootstrap/win/win_tools.bat#newcode167 bootstrap/win/win_tools.bat:167: exit 123 If your'e going to do magic ...

4 years, 8 months ago (2016-04-04 15:19:31 UTC) #2

Michael Moss

4 years, 8 months ago (2016-04-04 16:19:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 299677.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages