Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1848353002: S390: Assembler changes for enabling GrowHeap in Wasm (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Assembler changes for enabling GrowHeap in Wasm Port e1a7c1e76c150713339bc5ba4ce84d7eb6a5420a Original commit message: - New RelocInfo mode WASM_MEMORY_REFERENCE as a marker for wasm code objects that need to be relocated on a heap change - RelocInfo mode recorded for immediates that use the memory buffer as base - Tests to verify address patching works R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/d8cd323d6ea75ba86628ab8c311dea1b445cc1fa Cr-Commit-Position: refs/heads/master@{#35215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/s390/assembler-s390-inl.h View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-01 17:52:20 UTC) #1
JoranSiu
On 2016/04/01 17:52:20, john.yan wrote: > PTAL lgtm
4 years, 8 months ago (2016-04-01 17:57:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848353002/1
4 years, 8 months ago (2016-04-01 18:02:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 18:23:43 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 18:25:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8cd323d6ea75ba86628ab8c311dea1b445cc1fa
Cr-Commit-Position: refs/heads/master@{#35215}

Powered by Google App Engine
This is Rietveld 408576698