src/IceInstX8664.cpp - Issue 1848303003: Simplify references to command line flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX8664.cpp

Issue 1848303003: Simplify references to command line flags. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Remove fixed TODO Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX8664.cpp

diff --git a/src/IceInstX8664.cpp b/src/IceInstX8664.cpp

index ec2d140613fb6b5d5a8372d87f9ddaa9a8c2ccdf..0915bc840d9a7f5d63843b949a6062d1d595bde0 100644

--- a/src/IceInstX8664.cpp

+++ b/src/IceInstX8664.cpp

@@ -134,7 +134,7 @@ void TargetX8664Traits::X86OperandMem::emit(const Cfg *Func) const {

// TODO(sehr): ConstantRelocatable still needs updating for

// rematerializable base/index and Disp.

assert(Disp == 0);

- const bool UseNonsfi = Func->getContext()->getFlags().getUseNonsfi();

+ const bool UseNonsfi = getFlags().getUseNonsfi();

CR->emitWithoutPrefix(Target, UseNonsfi ? "@GOTOFF" : "");

assert(!UseNonsfi);

if (Base == nullptr && Index == nullptr) {

« src/IceFixups.h ('K') | « src/IceInstX8632.cpp ('k') | src/IceInstX86BaseImpl.h » ('j') | no next file with comments »