dart2js: Do not use the async rewriter on nested functions.

dart2js: Do not use the async rewriter on nested functions.

Nested functions in JS can be introduced by foreign code in our own
libraries.  They are always plain synchronous non-generator JS functions so
it is unnecessary to rewrite them.  Trying to do so will crash, because the
pre-translation analysis does not analyze them.  The translation wouldn't
do the right thing anyway.

Closes https://github.com/dart-lang/sdk/issues/25396

BUG=
R=sigmund@google.com, sigurdm@google.com

Committed: https://github.com/dart-lang/sdk/commit/78998a518c96400807b5897ac9519167fbe740d6

[Kevin Millikin (Google), 2016-04-01 12:55:45]

Description was changed from

==========
dart2js: Do not use the async rewriter on nested functions.

Nested functions in JS can be introduced by foreign code in our own
libraries.  They are always plain synchronous non-generator JS functions so
it is unnecessary to rewrite them.  Trying to do so will crash, because the
pre-translation analysis does not analyzer them.  The translation wouldn't
do the right thing anyway.

Closes https://github.com/dart-lang/sdk/issues/25396

BUG=
==========

to

==========
dart2js: Do not use the async rewriter on nested functions.

Nested functions in JS can be introduced by foreign code in our own
libraries.  They are always plain synchronous non-generator JS functions so
it is unnecessary to rewrite them.  Trying to do so will crash, because the
pre-translation analysis does not analyze them.  The translation wouldn't
do the right thing anyway.

Closes https://github.com/dart-lang/sdk/issues/25396

BUG=
==========

[Kevin Millikin (Google), 2016-04-01 12:56:51]

kmillikin@google.com changed reviewers:
+ sigmund@google.com, sigurdm@google.com

[Siggi Cherem (dart-lang), 2016-04-01 17:44:08]

lgtm!

[sigurdm, 2016-04-04 07:04:58]

LGTM
Thanks for fixing this!

[Kevin Millikin (Google), 2016-04-04 07:33:39]

Description was changed from

==========
dart2js: Do not use the async rewriter on nested functions.

Nested functions in JS can be introduced by foreign code in our own
libraries.  They are always plain synchronous non-generator JS functions so
it is unnecessary to rewrite them.  Trying to do so will crash, because the
pre-translation analysis does not analyze them.  The translation wouldn't
do the right thing anyway.

Closes https://github.com/dart-lang/sdk/issues/25396

BUG=
==========

to

==========
dart2js: Do not use the async rewriter on nested functions.

Nested functions in JS can be introduced by foreign code in our own
libraries.  They are always plain synchronous non-generator JS functions so
it is unnecessary to rewrite them.  Trying to do so will crash, because the
pre-translation analysis does not analyze them.  The translation wouldn't
do the right thing anyway.

Closes https://github.com/dart-lang/sdk/issues/25396

BUG=
R=sigmund@google.com, sigurdm@google.com

Committed:
https://github.com/dart-lang/sdk/commit/78998a518c96400807b5897ac9519167fbe740d6
==========

[Kevin Millikin (Google), 2016-04-04 07:33:41]

Committed patchset #1 (id:1) manually as
78998a518c96400807b5897ac9519167fbe740d6 (presubmit successful).