Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1848243002: [turbofan] Introduce JSToInteger and JSToLength operators. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce JSToInteger and JSToLength operators. These operators will be easier to optimize, and we can remove some unnecessary clutter from the intrinsic lowering. Drive-by-cleanup: Some alpha sorting of the type conversion operator business. R=mstarzinger@chromium.org Committed: https://crrev.com/10b365abffd55f52397bfa642c97255fff81b2f8 Cr-Commit-Position: refs/heads/master@{#35197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -104 lines) Patch
M src/compiler/js-generic-lowering.cc View 2 chunks +7 lines, -35 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 4 chunks +5 lines, -48 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +49 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +15 lines, -7 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-01 09:16:52 UTC) #1
Benedikt Meurer
Hey Michi, Here's a simple refactoring to reduce the clutter in JSIntrinsicLowering and bring those ...
4 years, 8 months ago (2016-04-01 09:18:29 UTC) #2
Michael Starzinger
LGTM.
4 years, 8 months ago (2016-04-01 09:55:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848243002/1
4 years, 8 months ago (2016-04-01 10:26:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 10:28:50 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 10:30:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10b365abffd55f52397bfa642c97255fff81b2f8
Cr-Commit-Position: refs/heads/master@{#35197}

Powered by Google App Engine
This is Rietveld 408576698