Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184823011: Explicitly don't support the make gyp generator. (Closed)

Created:
6 years, 9 months ago by viettrungluu
Modified:
6 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Explicitly don't support the make gyp generator. Provide a friendly error message in gyp_chromium. R=thakis@chromium.org BUG=348686 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/gyp_chromium View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
6 years, 9 months ago (2014-03-04 02:11:40 UTC) #1
Nico
lgtmeh
6 years, 9 months ago (2014-03-04 02:16:44 UTC) #2
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 9 months ago (2014-03-04 02:17:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/184823011/1
6 years, 9 months ago (2014-03-04 02:19:19 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 08:21:54 UTC) #5
Message was sent while issue was closed. 
Change committed as 254721

Powered by Google App Engine
This is Rietveld 408576698