DevTools: do not cache details node, remove linkifier from presentation record.

Source/devtools/front_end/TimelineView.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 29 matching lines @@
 WebInspector.TimelineView = function(delegate, presentationModel, frameModel)
 {
     WebInspector.View.call(this);
     this.element.classList.add("timeline-view");
     this.element.classList.add("hbox");
 
     this._delegate = delegate;
     this._presentationModel = presentationModel;
     this._frameModel = frameModel;
     this._calculator = new WebInspector.TimelineCalculator(this._presentationModel);
+    this._linkifier = new WebInspector.Linkifier();
 
     this._boundariesAreValid = true;
     this._scrollTop = 0;
 
     this._recordsView = this._createRecordsView();
     this._recordsView.addEventListener(WebInspector.SplitView.Events.SidebarSizeChanged, this._sidebarResized, this);
     this._recordsView.show(this.element);
     this.element.appendChild(this._timelineGrid.gridHeaderElement);
 
     this._popoverHelper = new WebInspector.PopoverHelper(this.element, this._getPopoverAnchor.bind(this), this._showPopover.bind(this));
@@ skipping 200 matching lines @@
         this._timelineGrid.gridHeaderElement.style.width = this._itemsGraphsElement.offsetWidth + "px";
         this._scheduleRefresh(false, true);
     },
 
     _resetView: function()
     {
         this._windowStartTime = -1;
         this._windowEndTime = -1;
         this._boundariesAreValid = false;
         this._adjustScrollPosition(0);
+        this._linkifier.reset();
         this._closeRecordDetails();
         this._automaticallySizeWindow = true;
     },
 
     reset: function()
     {
         this._resetView();
         this._invalidateAndScheduleRefresh(true, true);
     },
 
     /**
      * @return {!Array.<!Element>}
      */
     elementsToRestoreScrollPositionsFor: function()
     {
         return [this._containerElement];
     },
 
     refreshRecords: function()
     {
-        this._resetView();
         this._automaticallySizeWindow = false;
         this._invalidateAndScheduleRefresh(false, true);
     },
 
     wasShown: function()
     {
         WebInspector.View.prototype.wasShown.call(this);
 
         if (!WebInspector.TimelinePanel._categoryStylesInitialized) {
             WebInspector.TimelinePanel._categoryStylesInitialized = true;
@@ skipping 213 matching lines @@
 
             if (i < startIndex) {
                 var lastChildIndex = i + record.visibleChildrenCount;
                 if (lastChildIndex >= startIndex && lastChildIndex < endIndex) {
                     var expandElement = new WebInspector.TimelineExpandableElement(this._expandElements);
                     var positions = this._calculator.computeBarGraphWindowPosition(record);
                     expandElement._update(record, i, positions.left - this._expandOffset, positions.width);
                 }
             } else {
                 if (!listRowElement) {
-                    listRowElement = new WebInspector.TimelineRecordListRow(selectRecordCallback, scheduleRefreshCallback).element;
+                    listRowElement = new WebInspector.TimelineRecordListRow(this._linkifier, selectRecordCallback, scheduleRefreshCallback).element;
                     this._sidebarListElement.appendChild(listRowElement);
                 }
                 if (!graphRowElement) {
                     graphRowElement = new WebInspector.TimelineRecordGraphRow(this._itemsGraphsElement, selectRecordCallback, scheduleRefreshCallback).element;
                     this._graphRowsElement.appendChild(graphRowElement);
                 }
 
                 listRowElement.row.update(record, visibleTop);
                 graphRowElement.row.update(record, this._calculator, this._expandOffset, i);
                 if (this._lastSelectedRecord === record) {
@@ skipping 258 matching lines @@
      * @param {!Element} anchor
      * @param {!WebInspector.Popover} popover
      */
     _showPopover: function(anchor, popover)
     {
         if (anchor.classList.contains("timeline-frame-strip")) {
             var frame = anchor._frame;
             popover.show(WebInspector.TimelineUIUtils.generatePopupContentForFrame(frame), anchor);
         } else {
             if (anchor.row && anchor.row._record)
-                anchor.row._record.generatePopupContent(showCallback);
+                anchor.row._record.generatePopupContent(this._linkifier, showCallback);
             else if (anchor._tasksInfo)
                 popover.show(WebInspector.TimelineUIUtils.generateMainThreadBarPopupContent(this._presentationModel, anchor._tasksInfo), anchor, null, null, WebInspector.Popover.Orientation.Bottom);
         }
 
         function showCallback(popupContent)
         {
             popover.show(popupContent, anchor);
         }
     },
 
@@ skipping 156 matching lines @@
      * @return {number}
      */
     boundarySpan: function()
     {
         return this._maximumBoundary - this._minimumBoundary;
     }
 }
 
 /**
  * @constructor
+ * @param {!WebInspector.Linkifier} linkifier
  * @param {function(!WebInspector.TimelinePresentationModel.Record)} selectRecord
  * @param {function()} scheduleRefresh
  */
-WebInspector.TimelineRecordListRow = function(selectRecord, scheduleRefresh)
+WebInspector.TimelineRecordListRow = function(linkifier, selectRecord, scheduleRefresh)
 {
     this.element = document.createElement("div");
     this.element.row = this;
     this.element.style.cursor = "pointer";
     this.element.addEventListener("click", this._onClick.bind(this), false);
     this.element.addEventListener("mouseover", this._onMouseOver.bind(this), false);
     this.element.addEventListener("mouseout", this._onMouseOut.bind(this), false);
+    this._linkifier = linkifier;
 
     // Warning is float right block, it goes first.
     this._warningElement = this.element.createChild("div", "timeline-tree-item-warning hidden");
 
     this._expandArrowElement = this.element.createChild("div", "timeline-tree-item-expand-arrow");
     this._expandArrowElement.addEventListener("click", this._onExpandClick.bind(this), false);
     var iconElement = this.element.createChild("span", "timeline-tree-icon");
     this._typeElement = this.element.createChild("span", "type");
 
     this._dataElement = this.element.createChild("span", "data dimmed");
     this._scheduleRefresh = scheduleRefresh;
     this._selectRecord = selectRecord;
 }
 
 WebInspector.TimelineRecordListRow.prototype = {
     update: function(record, offset)
     {
         this._record = record;
         this._offset = offset;
 
         this.element.className = "timeline-tree-item timeline-category-" + record.category.name;
         var paddingLeft = 5;
         var step = -3;
         for (var currentRecord = record.parent ? record.parent.parent : null; currentRecord; currentRecord = currentRecord.parent)
             paddingLeft += 12 / (Math.max(1, step++));
         this.element.style.paddingLeft = paddingLeft + "px";
         if (record.isBackground())
             this.element.classList.add("background");
 
-        this._typeElement.textContent = record.title;
+        this._typeElement.textContent = record.title();
 
         if (this._dataElement.firstChild)
             this._dataElement.removeChildren();
 
         this._warningElement.enableStyleClass("hidden", !record.hasWarnings() && !record.childHasWarnings());
         this._warningElement.enableStyleClass("timeline-tree-item-child-warning", record.childHasWarnings() && !record.hasWarnings());
 
-        if (record.detailsNode())
-            this._dataElement.appendChild(record.detailsNode());
+        var detailsNode = record.buildDetailsNode(this._linkifier);
+        if (detailsNode) {
+            this._dataElement.appendChild(document.createTextNode("("));
+            this._dataElement.appendChild(detailsNode);
+            this._dataElement.appendChild(document.createTextNode(")"));
+        }
         this._expandArrowElement.enableStyleClass("parent", record.children && record.children.length);
         this._expandArrowElement.enableStyleClass("expanded", record.visibleChildrenCount);
         this._record.setUserObject("WebInspector.TimelineRecordListRow", this);
     },
 
     highlight: function(regExp, domChanges)
     {
         var matchInfo = this.element.textContent.match(regExp);
         if (matchInfo)
             WebInspector.highlightSearchResult(this.element, matchInfo.index, matchInfo[0].length, domChanges);
@@ skipping 193 matching lines @@
             this._element.classList.remove("hidden");
         } else
             this._element.classList.add("hidden");
     },
 
     _dispose: function()
     {
         this._element.remove();
     }
 }