DevTools: do not cache details node, remove linkifier from presentation record.

Source/devtools/front_end/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 359 matching lines @@
 WebInspector.TimelineUIUtils.generatePopupContentForFrameStatistics = function(statistics)
 {
     /**
      * @param {number} time
      */
     function formatTimeAndFPS(time)
     {
         return WebInspector.UIString("%s (%.0f FPS)", Number.millisToString(time, true), 1 / time);
     }
 
-    var contentHelper = new WebInspector.TimelineDetailsContentHelper(false);
+    var contentHelper = new WebInspector.TimelineDetailsContentHelper(new WebInspector.Linkifier(), false);

[caseq, 2014/03/03 07:53:15]

So what happens to locations created by the linkifier?

[pfeldman, 2014/03/03 09:16:48]

It is never called here.

     contentHelper.appendTextRow(WebInspector.UIString("Minimum Time"), formatTimeAndFPS(statistics.minDuration));
     contentHelper.appendTextRow(WebInspector.UIString("Average Time"), formatTimeAndFPS(statistics.average));
     contentHelper.appendTextRow(WebInspector.UIString("Maximum Time"), formatTimeAndFPS(statistics.maxDuration));
     contentHelper.appendTextRow(WebInspector.UIString("Standard Deviation"), Number.millisToString(statistics.stddev, true));
 
     return contentHelper.element;
 }
 
 /**
  * @param {!CanvasRenderingContext2D} context
@@ skipping 129 matching lines @@
     appendTextRow: function(title, content)
     {
         var row = document.createElement("tr");
         row.appendChild(this._createCell(title, "timeline-details-row-title"));
         row.appendChild(this._createCell(content, "timeline-details-row-data"));
         this._contentTable.appendChild(row);
     },
 
     /**
      * @param {string} title
-     * @param {!Element|string} content
+     * @param {!Node|string} content
      */
     appendElementRow: function(title, content)
     {
         var row = document.createElement("tr");
         var titleCell = this._createCell(title, "timeline-details-row-title");
         row.appendChild(titleCell);
         var cell = document.createElement("td");
         cell.className = "details";
         if (content instanceof Node)
             cell.appendChild(content);
         else
             cell.createTextChild(content || "");
         row.appendChild(cell);
         this._contentTable.appendChild(row);
     }
 }
 
 /**
  * @constructor
+ * @param {!WebInspector.Linkifier} linkifier
  * @param {boolean} monospaceValues
  */
-WebInspector.TimelineDetailsContentHelper = function(monospaceValues)
+WebInspector.TimelineDetailsContentHelper = function(linkifier, monospaceValues)
 {
+    this._linkifier = linkifier;

[caseq, 2014/03/03 07:53:15]

one

[pfeldman, 2014/03/03 09:16:48]

Done.

     this.element = document.createElement("div");
     this.element.className = "timeline-details-view-block";
     this._monospaceValues = monospaceValues;
+    this._linkifier = new WebInspector.Linkifier();

[caseq, 2014/03/03 07:53:15]

two

[pfeldman, 2014/03/03 09:16:48]

Done.

 }
 
 WebInspector.TimelineDetailsContentHelper.prototype = {
     /**
      * @param {string} title
      * @param {string|number|boolean} value
      */
     appendTextRow: function(title, value)
     {
         var rowElement = this.element.createChild("div", "timeline-details-view-row");
         rowElement.createChild("span", "timeline-details-view-row-title").textContent = WebInspector.UIString("%s: ", title);
         rowElement.createChild("span", "timeline-details-view-row-value" + (this._monospaceValues ? " monospace" : "")).textContent = value;
     },
 
     /**
      * @param {string} title
-     * @param {!Element|string} content
+     * @param {!Node|string} content
      */
     appendElementRow: function(title, content)
     {
         var rowElement = this.element.createChild("div", "timeline-details-view-row");
         rowElement.createChild("span", "timeline-details-view-row-title").textContent = WebInspector.UIString("%s: ", title);
         var valueElement = rowElement.createChild("span", "timeline-details-view-row-details" + (this._monospaceValues ? " monospace" : ""));
         if (content instanceof Node)
             valueElement.appendChild(content);
         else
             valueElement.createTextChild(content || "");
     },
 
     /**
      * @param {string} title
+     * @param {string} url
+     * @param {number} line
+     */
+    appendLocationRow: function(title, url, line)
+    {
+        this.appendElementRow(title, this._linkifier.linkifyLocation(url, line - 1) || "");
+    },
+
+    /**
+     * @param {string} title
      * @param {!Array.<!ConsoleAgent.CallFrame>} stackTrace
-     * @param {function(!ConsoleAgent.CallFrame)} callFrameLinkifier
      */
-    appendStackTrace: function(title, stackTrace, callFrameLinkifier)
+    appendStackTrace: function(title, stackTrace)
     {
         var rowElement = this.element.createChild("div", "timeline-details-view-row");
         rowElement.createChild("span", "timeline-details-view-row-title").textContent = WebInspector.UIString("%s: ", title);
         var stackTraceElement = rowElement.createChild("div", "timeline-details-view-row-stack-trace monospace");
 
         for (var i = 0; i < stackTrace.length; ++i) {
             var stackFrame = stackTrace[i];
             var row = stackTraceElement.createChild("div");
             row.createTextChild(stackFrame.functionName || WebInspector.UIString("(anonymous function)"));
             row.createTextChild(" @ ");
-            var urlElement = callFrameLinkifier(stackFrame);
+            var urlElement = this._linkifier.linkifyLocation(stackFrame.url, stackFrame.lineNumber - 1);
             row.appendChild(urlElement);
         }
     }
 }