Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1848203003: clovis: Add a method to slim a trace by dropping large objects. (Closed)

Created:
4 years, 8 months ago by Benoit L
Modified:
4 years, 8 months ago
Reviewers:
mattcary
CC:
chromium-reviews, mikecase+watch_chromium.org, gabadie+watch_chromium.org, jbudorick+watch_chromium.org, lizeb+watch-android-loading_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clovis: Add a method to slim a trace by dropping large objects. JSON is less expensive than objects for trace events. A ~45MB trace file expands to more than 500MB of memory. This CL adds a method to return the trace to its JSON format. This increases the peak memory usage when processing a single trace (and the processing time, since serializing the trace is not free), but reduces the total memory cost when holding several traces at once. Committed: https://crrev.com/65f484b3674d177e98ed04aa2ec30482e05a6c3a Cr-Commit-Position: refs/heads/master@{#384548}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M tools/android/loading/loading_trace.py View 1 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Benoit L
Hi, I'm not 100% convinced that this will help that much, the proper solution is ...
4 years, 8 months ago (2016-04-01 09:40:34 UTC) #2
mattcary
lgtm Worth a shot. I agree that serializing the graph is the right way to ...
4 years, 8 months ago (2016-04-01 10:36:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848203003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848203003/20001
4 years, 8 months ago (2016-04-01 10:57:21 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-01 11:32:47 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 11:33:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65f484b3674d177e98ed04aa2ec30482e05a6c3a
Cr-Commit-Position: refs/heads/master@{#384548}

Powered by Google App Engine
This is Rietveld 408576698