Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1848203002:
Fix some formatting glitches in the Windows build instructions. (Closed)
DescriptionFix some formatting glitches in the Windows build instructions.
The auto-generated markdown introduced some formatting anomalies. I also
list-ified some things to (hopefully) give the doc a more structured
appearance.
BUG=none
R=tfarina@chromium.org
Committed: https://chromium.googlesource.com/chromium/src/+/8f817e34c633f797e2117ca2e650139fa7fa7572
Patch Set 1 #
Total comments: 5
Messages
Total messages: 12 (4 generated)
dcheng@chromium.org changed reviewers: + brucedawson@chromium.org
Pointed out by a friend who was trying to build Chromium. https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_in... currently has a bunch of spurious backslashes, and some other formatting from sites didn't carry over very well. (At least in the local preview, it looks better; hopefully, it translates well to Gitiles' markdown)
tfarina@chromium.org changed reviewers: + dpranke@chromium.org, tfarina@chromium.org
I told Bruce and Dirk that I noticed this and was going to send a patch for it, but I didn't find time to do it. lgtm Thanks.
https://codereview.chromium.org/1848203002/diff/1/docs/windows_build_instruct... File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1848203002/diff/1/docs/windows_build_instruct... docs/windows_build_instructions.md:17: [depot\_tools](http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up). also remove \ here?
https://codereview.chromium.org/1848203002/diff/1/docs/windows_build_instruct... File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1848203002/diff/1/docs/windows_build_instruct... docs/windows_build_instructions.md:17: [depot\_tools](http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up). On 2016/04/01 at 11:15:28, tfarina wrote: > also remove \ here? This one is necessary (I think). Inside code blocks, special formatting characters like * and _ are ignored, but not inside links. I /think/. In any case, it currently displays correctly on Gitiles, so I'm afraid to touch it =)
Message was sent while issue was closed.
Description was changed from ========== Fix some formatting glitches in the Windows build instructions. The auto-generated markdown introduced some formatting anomalies. I also list-ified some things to (hopefully) give the doc a more structured appearance. BUG=none ========== to ========== Fix some formatting glitches in the Windows build instructions. The auto-generated markdown introduced some formatting anomalies. I also list-ified some things to (hopefully) give the doc a more structured appearance. BUG=none R=tfarina@chromium.org Committed: https://crrev.com/8f817e34c633f797e2117ca2e650139fa7fa7572 Cr-Commit-Position: refs/heads/master@{#384617} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8f817e34c633f797e2117ca2e650139fa7fa7572 Cr-Commit-Position: refs/heads/master@{#384617}
Message was sent while issue was closed.
Description was changed from ========== Fix some formatting glitches in the Windows build instructions. The auto-generated markdown introduced some formatting anomalies. I also list-ified some things to (hopefully) give the doc a more structured appearance. BUG=none R=tfarina@chromium.org Committed: https://crrev.com/8f817e34c633f797e2117ca2e650139fa7fa7572 Cr-Commit-Position: refs/heads/master@{#384617} ========== to ========== Fix some formatting glitches in the Windows build instructions. The auto-generated markdown introduced some formatting anomalies. I also list-ified some things to (hopefully) give the doc a more structured appearance. BUG=none R=tfarina@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8f817e34c633f797e2117ca2e650... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 8f817e34c633f797e2117ca2e650139fa7fa7572 (presubmit successful).
Message was sent while issue was closed.
Too late, but oh well. https://codereview.chromium.org/1848203002/diff/1/docs/windows_build_instruct... File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1848203002/diff/1/docs/windows_build_instruct... docs/windows_build_instructions.md:22: ####For building with Visual Studio 2015 (default compiler as of March 10, 2016): The switchover date was actually March 11, 2016. My bad. Not important however. https://codereview.chromium.org/1848203002/diff/1/docs/windows_build_instruct... docs/windows_build_instructions.md:24: Install Visual Studio 2015 Update 1 or later - Community Edition Why are we removing the indenting? I know it's not showing up properly on gitiles but that is a gitiles bug (https://code.google.com/p/gitiles/issues/detail?id=105).
Message was sent while issue was closed.
(I'll fix the date too, because why not) https://codereview.chromium.org/1848203002/diff/1/docs/windows_build_instruct... File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1848203002/diff/1/docs/windows_build_instruct... docs/windows_build_instructions.md:24: Install Visual Studio 2015 Update 1 or later - Community Edition On 2016/04/01 at 17:35:25, brucedawson wrote: > Why are we removing the indenting? I know it's not showing up properly on gitiles but that is a gitiles bug (https://code.google.com/p/gitiles/issues/detail?id=105). I did look at the original sites page and noticed it was indented, but couldn't find an equivalent that was working in markdown. However, I didn't realize this was a gitiles bug: since it didn't have an effect in the local preview either, I thought it was just another artifact from the automated conversion. I'll add the blockquoting back in a followup. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
