Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1848153002: Escape slashes in paths in windows tool bootstrapping. (Closed)

Created:
4 years, 8 months ago by iannucci
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Escape slashes in paths in windows tool bootstrapping. Otherwise the 7zip extraction process will interpret them as escape chars. BUG=595883 R=martiniss@chromium.org, mmoss@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M bootstrap/win/win_tools.bat View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
PTAL: Super tiny fix, who can stamp first? :)
4 years, 8 months ago (2016-04-01 00:11:56 UTC) #2
Michael Moss
lgtm
4 years, 8 months ago (2016-04-01 00:14:22 UTC) #3
martiniss
lgtm
4 years, 8 months ago (2016-04-01 00:14:41 UTC) #5
martiniss
On 2016/04/01 at 00:14:41, martiniss wrote: > lgtm dang I lost
4 years, 8 months ago (2016-04-01 00:14:46 UTC) #6
iannucci
4 years, 8 months ago (2016-04-01 00:17:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 299611.

Powered by Google App Engine
This is Rietveld 408576698