Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184813005: Make Document::implementation() method return reference (Closed)

Created:
6 years, 9 months ago by maheshkk
Modified:
6 years, 9 months ago
Reviewers:
Inactive
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make Document::implementation() method return reference DOMImplementation can not be null and this CL only makes implementation() return a reference instead of pointer. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168436

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
maheshkk
PTAL
6 years, 9 months ago (2014-02-28 22:37:57 UTC) #1
Inactive
lgtm
6 years, 9 months ago (2014-02-28 22:40:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/184813005/1
6 years, 9 months ago (2014-02-28 22:40:28 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-01 00:16:13 UTC) #4
commit-bot: I haz the power
Retried try job too often on blink_android_compile_rel for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_android_compile_rel&number=1137
6 years, 9 months ago (2014-03-01 00:16:13 UTC) #5
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 9 months ago (2014-03-03 18:06:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/184813005/1
6 years, 9 months ago (2014-03-03 18:06:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/184813005/1
6 years, 9 months ago (2014-03-03 23:19:41 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 06:23:24 UTC) #9
Message was sent while issue was closed. 
Change committed as 168436

Powered by Google App Engine
This is Rietveld 408576698