Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 184813004: Create response_parameters as part of mojom (Closed)

Created:
6 years, 9 months ago by DaveMoore
Modified:
6 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Create response_parameters as part of mojom BUG=None TEST=None R=darin@chromium.org, darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254288

Patch Set 1 #

Patch Set 2 : Fix up mojom files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -15 lines) Patch
M mojo/public/bindings/pylib/generate/mojom.py View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/public/bindings/pylib/generate/mojom_data.py View 3 chunks +11 lines, -3 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_lexer.py View 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_parser.py View 1 chunk +8 lines, -2 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_translate.py View 1 chunk +6 lines, -3 lines 0 comments Download
M mojo/public/bindings/tests/math_calculator.mojom View 1 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/bindings/tests/sample_service.mojom View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaveMoore
Fix up mojom files
6 years, 9 months ago (2014-02-28 22:35:56 UTC) #1
DaveMoore
This also moved the method ordinal from the end to right after the method name. ...
6 years, 9 months ago (2014-02-28 22:37:54 UTC) #2
darin (slow to review)
LGTM
6 years, 9 months ago (2014-02-28 23:28:13 UTC) #3
DaveMoore
6 years, 9 months ago (2014-03-01 00:23:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r254288 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698