Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 1848083003: Add enable_webrtc_remoting_client config in remoting_client_jni. (Closed)

Created:
4 years, 8 months ago by Sergey Ulanov
Modified:
4 years, 8 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org, Yuwei
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add enable_webrtc_remoting_client config in remoting_client_jni. The ENABLE_WEBRTC_REMOTING_CLIENT define wasn't properly passed to the JNI code, so it was ignoring the useWebrtc flag. TBR=lambroslambrou@chromium.org Committed: https://crrev.com/084c95399deeec528b3ebb6e543f83e366ac99cb Cr-Commit-Position: refs/heads/master@{#384741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Sergey Ulanov
4 years, 8 months ago (2016-04-01 21:30:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848083003/1
4 years, 8 months ago (2016-04-01 21:30:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 00:05:13 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 00:06:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/084c95399deeec528b3ebb6e543f83e366ac99cb
Cr-Commit-Position: refs/heads/master@{#384741}

Powered by Google App Engine
This is Rietveld 408576698