Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm

Issue 1848063002: Fix page navigation being incorrectly fired on Mac OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename variable, add comments and remove ack in unittest Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegat e.h" 5 #import "chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegat e.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
10 #include "chrome/browser/devtools/devtools_window.h" 10 #include "chrome/browser/devtools/devtools_window.h"
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
186 } 186 }
187 187
188 return NO; 188 return NO;
189 } 189 }
190 190
191 - (void)rendererHandledWheelEvent:(const blink::WebMouseWheelEvent&)event 191 - (void)rendererHandledWheelEvent:(const blink::WebMouseWheelEvent&)event
192 consumed:(BOOL)consumed { 192 consumed:(BOOL)consumed {
193 [historySwiper_ rendererHandledWheelEvent:event consumed:consumed]; 193 [historySwiper_ rendererHandledWheelEvent:event consumed:consumed];
194 } 194 }
195 195
196 - (void)rendererHandledGestureScrollEvent:(const blink::WebGestureEvent&)event
197 consumed:(BOOL)consumed {
198 [historySwiper_ rendererHandledGestureScrollEvent:event consumed:consumed];
199 }
200
196 // Spellchecking methods 201 // Spellchecking methods
197 // The next five methods are implemented here since this class is the first 202 // The next five methods are implemented here since this class is the first
198 // responder for anything in the browser. 203 // responder for anything in the browser.
199 204
200 // This message is sent whenever the user specifies that a word should be 205 // This message is sent whenever the user specifies that a word should be
201 // changed from the spellChecker. 206 // changed from the spellChecker.
202 - (void)changeSpelling:(id)sender { 207 - (void)changeSpelling:(id)sender {
203 // Grab the currently selected word from the spell panel, as this is the word 208 // Grab the currently selected word from the spell panel, as this is the word
204 // that we want to replace the selected word in the text with. 209 // that we want to replace the selected word in the text with.
205 NSString* newWord = [[sender selectedCell] stringValue]; 210 NSString* newWord = [[sender selectedCell] stringValue];
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 } 255 }
251 256
252 - (void)spellCheckEnabled:(BOOL)enabled checked:(BOOL)checked { 257 - (void)spellCheckEnabled:(BOOL)enabled checked:(BOOL)checked {
253 spellcheckEnabled_ = enabled; 258 spellcheckEnabled_ = enabled;
254 spellcheckChecked_ = checked; 259 spellcheckChecked_ = checked;
255 } 260 }
256 261
257 // END Spellchecking methods 262 // END Spellchecking methods
258 263
259 @end 264 @end
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698