Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1848033006: Mus version of GLHelper (Closed)

Created:
4 years, 8 months ago by rjkroege
Modified:
4 years, 8 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus version of GLHelper Pending the completion of the ongoing componentization of the GPU code, add a version of content's GLHelper customized to Mus. BUG=596549 Committed: https://crrev.com/535fbdccc37f44292266fb16a2e21980b3ef1ce3 Cr-Commit-Position: refs/heads/master@{#385516}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fixed deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -0 lines) Patch
M components/mus/gles2/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A components/mus/gles2/gl_helper.h View 1 chunk +23 lines, -0 lines 0 comments Download
A components/mus/gles2/gl_helper.cc View 1 chunk +108 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
rjkroege
PTAL
4 years, 8 months ago (2016-04-01 23:36:21 UTC) #2
Fady Samuel
lgtm
4 years, 8 months ago (2016-04-01 23:51:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848033006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848033006/20001
4 years, 8 months ago (2016-04-05 01:13:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/139461) linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-05 01:18:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848033006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848033006/40001
4 years, 8 months ago (2016-04-06 18:13:11 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 18:57:55 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 18:59:22 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/535fbdccc37f44292266fb16a2e21980b3ef1ce3
Cr-Commit-Position: refs/heads/master@{#385516}

Powered by Google App Engine
This is Rietveld 408576698