Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1848033005: Revert of 🍬 GN: Make breakpad_unittests & sandbox_linux_unittests use test() (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@test-minor-renames
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🍬 GN: Make breakpad_unittests & sandbox_linux_unittests use test() (patchset #8 id:140001 of https://codereview.chromium.org/1841193002/ ) Reason for revert: breaks both suites on GN, e.g. https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester Original issue's description: > GN: Make breakpad_unittests & sandbox_linux_unittests use test() > > This simplifies build rules for native tests, and allows us to get rid > of ${target}_deps targets (once recipes are updated). > > This change fixes the generated wrapper scripts, which didn't work. > > BUG=589318 > > Committed: https://crrev.com/638c8c12c9cd5086d4ba8704852cb1167e7b4ae9 > Cr-Commit-Position: refs/heads/master@{#384348} TBR=mark@chromium.org,dpranke@chromium.org,jorgelo@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=589318 Committed: https://crrev.com/cb514fa85364e415c7ce4f6a8365e78a00fe7dfb Cr-Commit-Position: refs/heads/master@{#384571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -186 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M breakpad/BUILD.gn View 3 chunks +26 lines, -3 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance.py View 2 chunks +5 lines, -24 lines 0 comments Download
M build/android/test_runner.py View 1 chunk +0 lines, -2 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 chunk +7 lines, -17 lines 0 comments Download
M build/config/android/rules.gni View 2 chunks +37 lines, -21 lines 0 comments Download
M sandbox/linux/BUILD.gn View 2 chunks +39 lines, -8 lines 0 comments Download
M testing/test.gni View 2 chunks +94 lines, -110 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jbudorick
Created Revert of 🍬 GN: Make breakpad_unittests & sandbox_linux_unittests use test()
4 years, 8 months ago (2016-04-01 13:36:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848033005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848033005/1
4 years, 8 months ago (2016-04-01 13:36:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 13:37:11 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cb514fa85364e415c7ce4f6a8365e78a00fe7dfb Cr-Commit-Position: refs/heads/master@{#384571}
4 years, 8 months ago (2016-04-01 13:38:14 UTC) #5
agrieve
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1854733003/ by agrieve@chromium.org. ...
4 years, 8 months ago (2016-04-01 14:34:15 UTC) #6
Dirk Pranke
4 years, 8 months ago (2016-04-01 16:52:04 UTC) #7
Message was sent while issue was closed.
lgtm stamp

Powered by Google App Engine
This is Rietveld 408576698