Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1848003002: s390: Remove usages of Heap::NewSpaceStart and its external reference (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: Remove usages of Heap::NewSpaceStart and its external reference Port f2a585935fa070d2b4fb78389045d4df5253dd96 Original commit message: Replace the uses with proper page flag lookups. R=mlippautz@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:581412 LOG=N TEST=mjsunit/allocation-site-info Committed: https://crrev.com/e3fb2e734142e3f666f3d2d1bb1154924b5a8041 Cr-Commit-Position: refs/heads/master@{#35179}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add kNear #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -22 lines) Patch
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.h View 1 chunk +6 lines, -4 lines 0 comments Download
M src/crankshaft/s390/lithium-s390.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/s390/codegen-s390.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 1 chunk +36 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-03-31 19:16:31 UTC) #1
JoranSiu
https://codereview.chromium.org/1848003002/diff/1/src/s390/macro-assembler-s390.cc File src/s390/macro-assembler-s390.cc (right): https://codereview.chromium.org/1848003002/diff/1/src/s390/macro-assembler-s390.cc#newcode3730 src/s390/macro-assembler-s390.cc:3730: beq(&top_check); Please add Label::kNear here. https://codereview.chromium.org/1848003002/diff/1/src/s390/macro-assembler-s390.cc#newcode3738 src/s390/macro-assembler-s390.cc:3738: b(&map_check); Please ...
4 years, 8 months ago (2016-03-31 19:24:19 UTC) #2
john.yan
On 2016/03/31 19:24:19, JoranSiu wrote: > https://codereview.chromium.org/1848003002/diff/1/src/s390/macro-assembler-s390.cc > File src/s390/macro-assembler-s390.cc (right): > > https://codereview.chromium.org/1848003002/diff/1/src/s390/macro-assembler-s390.cc#newcode3730 > ...
4 years, 8 months ago (2016-03-31 19:29:37 UTC) #3
JoranSiu
On 2016/03/31 19:29:37, john.yan wrote: > On 2016/03/31 19:24:19, JoranSiu wrote: > > > https://codereview.chromium.org/1848003002/diff/1/src/s390/macro-assembler-s390.cc ...
4 years, 8 months ago (2016-03-31 19:31:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848003002/20001
4 years, 8 months ago (2016-03-31 19:35:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 19:56:35 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 19:57:44 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3fb2e734142e3f666f3d2d1bb1154924b5a8041
Cr-Commit-Position: refs/heads/master@{#35179}

Powered by Google App Engine
This is Rietveld 408576698