Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1847983002: [SVG] Compensate for container size snapping (Closed)

Created:
4 years, 8 months ago by f(malita)
Modified:
4 years, 8 months ago
Reviewers:
Stephen Chennney, pdr., fs
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SVG] Compensate for container size snapping BoxPainter rounds its box rect coordinates to ensure optimal alignment and minimize AA bleed. SVGRootPainter attempts to do the same, but it only adjusts the offset. Since int-snapping may also change the size, the SVG content transform needs to take this residual scale into account (such that it maps onto the full int-snapped area). BUG=599095 R=schenney@chromium.org,fs@opera.com,pdr@chromium.org Committed: https://crrev.com/d1d05d02de7519c777358ce926c007a7222449d6 Cr-Commit-Position: refs/heads/master@{#384580}

Patch Set 1 #

Patch Set 2 : test + expectations #

Patch Set 3 : more expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/zoomed-background-alignment.html View 1 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/zoomed-background-alignment-expected.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGRootPainter.cpp View 2 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
f(malita)
10 minor rebaselines: https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel_ng/203274/layout-test-results/results.html
4 years, 8 months ago (2016-03-31 20:09:02 UTC) #4
Stephen Chennney
LGTM. It's worth also checking that the page from the original bug report looks correct ...
4 years, 8 months ago (2016-03-31 20:26:12 UTC) #5
f(malita)
On 2016/03/31 20:26:12, Stephen Chenney wrote: > LGTM. It's worth also checking that the page ...
4 years, 8 months ago (2016-03-31 20:42:51 UTC) #6
f(malita)
On 2016/03/31 20:42:51, f(malita) wrote: > On 2016/03/31 20:26:12, Stephen Chenney wrote: > > LGTM. ...
4 years, 8 months ago (2016-03-31 20:59:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847983002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847983002/40001
4 years, 8 months ago (2016-04-01 12:40:51 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-01 14:26:18 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 14:27:34 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d1d05d02de7519c777358ce926c007a7222449d6
Cr-Commit-Position: refs/heads/master@{#384580}

Powered by Google App Engine
This is Rietveld 408576698