Switch SkMatrixImageFilter over to new onFilterImage interface

Switch SkMatrixImageFilter over to new onFilterImage interface

TBR=reed@google.com

GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1847953003

Committed: https://skia.googlesource.com/skia/+/08541d5340a9cadcca60b2f04b1f2dde73be2587

[robertphillips, 2016-03-31 18:45:31]

Description was changed from

==========
Switch SkMatrixImageFilter over to new onFilterImage interface
==========

to

==========
Switch SkMatrixImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-31 18:48:20]

Description was changed from

==========
Switch SkMatrixImageFilter over to new onFilterImage interface
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMatrixImageFilter over to new onFilterImage interface

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-03-31 18:48:20]

robertphillips@google.com changed reviewers:
+ reed@google.com, senorblanco@chromium.org, senorblanco@google.com

[Stephen White, 2016-03-31 19:01:52]

LGTM w/nit

https://codereview.chromium.org/1847953003/diff/1/src/core/SkMatrixImageFilter.h
File src/core/SkMatrixImageFilter.h (right):

https://codereview.chromium.org/1847953003/diff/1/src/core/SkMatrixImageFilte...
src/core/SkMatrixImageFilter.h:31: return new SkMatrixImageFilter(transform,
filterQuality, input);
Please don't make inline a function unless the profiler tells you it's 
necssary. Otherwise it just adds unnecessary dependencies, and may end 
up in multiple translation units.

[robertphillips, 2016-03-31 19:55:21]

https://codereview.chromium.org/1847953003/diff/1/src/core/SkMatrixImageFilter.h
File src/core/SkMatrixImageFilter.h (right):

https://codereview.chromium.org/1847953003/diff/1/src/core/SkMatrixImageFilte...
src/core/SkMatrixImageFilter.h:31: return new SkMatrixImageFilter(transform,
filterQuality, input);
On 2016/03/31 19:01:52, Stephen White wrote:
> Please don't make inline a function unless the profiler tells you it's 
> necssary. Otherwise it just adds unnecessary dependencies, and may end 
> up in multiple translation units.

Done.

[robertphillips, 2016-03-31 19:55:27]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 19:55:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847953003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847953003/20001

[commit-bot: I haz the power, 2016-04-01 11:50:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 11:50:34]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-04-01 14:12:41]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-04-01 14:12:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1847953003/#ps20001
(title: "Uninline Create method")

[commit-bot: I haz the power, 2016-04-01 14:12:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847953003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847953003/20001

[commit-bot: I haz the power, 2016-04-01 14:13:44]

Description was changed from

==========
Switch SkMatrixImageFilter over to new onFilterImage interface

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Switch SkMatrixImageFilter over to new onFilterImage interface

TBR=reed@google.com

GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/08541d5340a9cadcca60b2f04b1f2dde73be2587
==========

[commit-bot: I haz the power, 2016-04-01 14:13:45]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/08541d5340a9cadcca60b2f04b1f2dde73be2587