Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1847923002: Add CreatePlatformGLTestContext_none.cpp for Google3 build (Closed)

Created:
4 years, 8 months ago by bsalomon
Modified:
4 years, 8 months ago
Reviewers:
dogben
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@rename
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : exclude CreatePlatformGLTestContext_none when os has a real impl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M gyp/gputest.gyp View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + tools/gpu/gl/none/CreatePlatformGLTestContext_none.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
bsalomon
4 years, 8 months ago (2016-03-31 17:02:34 UTC) #3
dogben
lgtm
4 years, 8 months ago (2016-03-31 17:08:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847923002/1
4 years, 8 months ago (2016-03-31 18:24:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/7525)
4 years, 8 months ago (2016-03-31 18:26:36 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847923002/20001
4 years, 8 months ago (2016-03-31 18:41:57 UTC) #10
dogben
lgtm
4 years, 8 months ago (2016-03-31 19:44:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847923002/20001
4 years, 8 months ago (2016-03-31 20:57:08 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 11:50:49 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e5adad41415e4af7cb97ac6246457aff42820de6

Powered by Google App Engine
This is Rietveld 408576698