third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h - Issue 1847863002: Move notification resource loading from content/child to blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

Issue 1847863002: Move notification resource loading from content/child to blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp ('K') | « third_party/WebKit/public/blink_headers.gypi ('k') | third_party/WebKit/public/platform/modules/notifications/WebNotificationResources.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

diff --git a/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h b/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

index dd5387f8e2fab708add1e6fbce947bf06e3ac533..e83bf7ec9c432b9554ab78b038f76e22271c8a5c 100644

--- a/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

+++ b/third_party/WebKit/public/platform/modules/notifications/WebNotificationManager.h

@@ -10,6 +10,8 @@

#include "public/platform/WebVector.h"

#include "public/platform/modules/notifications/WebNotificationData.h"

#include "public/platform/modules/notifications/WebNotificationPermission.h"

+#include "public/platform/modules/notifications/WebNotificationResources.h"

+#include <memory>

#include <stdint.h>

namespace blink {

@@ -34,12 +36,12 @@ public:

// Shows a page notification on the user's system. These notifications will have their

// events delivered to the delegate specified in this call.

- virtual void show(const WebSecurityOrigin&, const WebNotificationData&, WebNotificationDelegate*) = 0;

+ virtual void show(const WebSecurityOrigin&, const WebNotificationData&, std::unique_ptr<WebNotificationResources>, WebNotificationDelegate*) = 0;

// Shows a persistent notification on the user's system. These notifications will have

// their events delivered to a Service Worker rather than the object's delegate. Will

// take ownership of the WebNotificationShowCallbacks object.

- virtual void showPersistent(const WebSecurityOrigin&, const WebNotificationData&, WebServiceWorkerRegistration*, WebNotificationShowCallbacks*) = 0;

+ virtual void showPersistent(const WebSecurityOrigin&, const WebNotificationData&, std::unique_ptr<WebNotificationResources>, WebServiceWorkerRegistration*, WebNotificationShowCallbacks*) = 0;

// Asynchronously gets the persistent notifications belonging to the Service Worker Registration.

// If |filterTag| is not an empty string, only the notification with the given tag will be