third_party/WebKit/Source/modules/modules.gypi - Issue 1847863002: Move notification resource loading from content/child to blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/modules.gypi

Issue 1847863002: Move notification resource loading from content/child to blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/DEPS ('k') | third_party/WebKit/Source/modules/notifications/Notification.h » ('j') | third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/modules.gypi

diff --git a/third_party/WebKit/Source/modules/modules.gypi b/third_party/WebKit/Source/modules/modules.gypi

index faaf3a768184aeb3de3685f66c1aa120de5cb759..e44423c67dda9e7387155b6566f886de9fe30ab8 100644

--- a/third_party/WebKit/Source/modules/modules.gypi

+++ b/third_party/WebKit/Source/modules/modules.gypi

@@ -1326,9 +1326,13 @@

'notifications/NotificationData.h',

'notifications/NotificationEvent.cpp',

'notifications/NotificationEvent.h',

+ 'notifications/NotificationImageLoader.cpp',

+ 'notifications/NotificationImageLoader.h',

'notifications/NotificationPermissionCallback.h',

'notifications/NotificationPermissionClient.cpp',

'notifications/NotificationPermissionClient.h',

+ 'notifications/NotificationResourcesLoader.cpp',

+ 'notifications/NotificationResourcesLoader.h',

'notifications/ServiceWorkerGlobalScopeNotifications.h',

'notifications/ServiceWorkerRegistrationNotifications.cpp',

'notifications/ServiceWorkerRegistrationNotifications.h',

@@ -1993,6 +1997,7 @@

'mediastream/MediaConstraintsTest.cpp',

'mediastream/RTCDataChannelTest.cpp',

'notifications/NotificationDataTest.cpp',

+ 'notifications/NotificationResourcesLoaderTest.cpp',

'payments/PaymentDetailsTestHelper.cpp',

'payments/PaymentRequestTest.cpp',

'payments/PaymentRequestDetailsTest.cpp',