content/content_child.gypi - Issue 1847863002: Move notification resource loading from content/child to blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/content_child.gypi

Issue 1847863002: Move notification resource loading from content/child to blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address peter's comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/notifications/pending_notifications_tracker_unittest.cc ('k') | content/content_tests.gypi » ('j') | third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/content_child.gypi

diff --git a/content/content_child.gypi b/content/content_child.gypi

index f4ac67d4a4c7f1f8456334a64dd4ad66cb306020..9ec8f240d956ffe9c1d5ff922dfcfbd3cf061e58 100644

--- a/content/content_child.gypi

+++ b/content/content_child.gypi

@@ -139,14 +139,8 @@

'child/notifications/notification_data_conversions.h',

'child/notifications/notification_dispatcher.cc',

'child/notifications/notification_dispatcher.h',

- 'child/notifications/notification_image_loader.cc',

- 'child/notifications/notification_image_loader.h',

'child/notifications/notification_manager.cc',

'child/notifications/notification_manager.h',

- 'child/notifications/pending_notification.cc',

- 'child/notifications/pending_notification.h',

- 'child/notifications/pending_notifications_tracker.cc',

- 'child/notifications/pending_notifications_tracker.h',

'child/permissions/permission_dispatcher.cc',

'child/permissions/permission_dispatcher.h',

'child/permissions/permission_dispatcher_thread_proxy.cc',