Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: content/child/notifications/notification_image_loader.cc

Issue 1847863002: Move notification resource loading from content/child to blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address peter's comments. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/notifications/notification_image_loader.cc
diff --git a/content/child/notifications/notification_image_loader.cc b/content/child/notifications/notification_image_loader.cc
deleted file mode 100644
index 4ad37f859941e4efe8232a278c06f28a5ff86f80..0000000000000000000000000000000000000000
--- a/content/child/notifications/notification_image_loader.cc
+++ /dev/null
@@ -1,121 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "content/child/notifications/notification_image_loader.h"
-
-#include "base/bind.h"
-#include "base/location.h"
-#include "base/logging.h"
-#include "base/metrics/histogram_macros.h"
-#include "base/single_thread_task_runner.h"
-#include "content/child/image_decoder.h"
-#include "third_party/WebKit/public/platform/Platform.h"
-#include "third_party/WebKit/public/platform/WebURL.h"
-#include "third_party/WebKit/public/platform/WebURLLoader.h"
-#include "third_party/WebKit/public/platform/WebURLRequest.h"
-#include "third_party/skia/include/core/SkBitmap.h"
-
-using blink::WebURL;
-using blink::WebURLError;
-using blink::WebURLLoader;
-using blink::WebURLRequest;
-
-namespace content {
-
-NotificationImageLoader::NotificationImageLoader(
- const ImageLoadCompletedCallback& callback,
- const scoped_refptr<base::SingleThreadTaskRunner>& worker_task_runner,
- const scoped_refptr<base::SingleThreadTaskRunner>& main_task_runner)
- : callback_(callback),
- worker_task_runner_(worker_task_runner),
- main_task_runner_(main_task_runner),
- completed_(false) {}
-
-NotificationImageLoader::~NotificationImageLoader() {
- DCHECK(main_task_runner_->BelongsToCurrentThread());
-}
-
-void NotificationImageLoader::StartOnMainThread(const GURL& image_url) {
- DCHECK(main_task_runner_->BelongsToCurrentThread());
- DCHECK(!url_loader_);
-
- start_time_ = base::TimeTicks::Now();
-
- WebURL image_web_url(image_url);
- WebURLRequest request(image_web_url);
- request.setRequestContext(WebURLRequest::RequestContextImage);
-
- url_loader_.reset(blink::Platform::current()->createURLLoader());
- url_loader_->loadAsynchronously(request, this);
-}
-
-void NotificationImageLoader::didReceiveData(WebURLLoader* loader,
- const char* data,
- int data_length,
- int encoded_data_length) {
- DCHECK(!completed_);
- DCHECK_GT(data_length, 0);
-
- buffer_.insert(buffer_.end(), data, data + data_length);
-}
-
-void NotificationImageLoader::didFinishLoading(
- WebURLLoader* loader,
- double finish_time,
- int64_t total_encoded_data_length) {
- DCHECK(!completed_);
-
- UMA_HISTOGRAM_LONG_TIMES("Notifications.Icon.LoadFinishTime",
- base::TimeTicks::Now() - start_time_);
-
- RunCallbackOnWorkerThread();
-}
-
-void NotificationImageLoader::didFail(WebURLLoader* loader,
- const WebURLError& error) {
- if (completed_)
- return;
-
- UMA_HISTOGRAM_LONG_TIMES("Notifications.Icon.LoadFailTime",
- base::TimeTicks::Now() - start_time_);
-
- RunCallbackOnWorkerThread();
-}
-
-void NotificationImageLoader::RunCallbackOnWorkerThread() {
- url_loader_.reset();
-
- completed_ = true;
- SkBitmap icon = GetDecodedImage();
-
- if (worker_task_runner_->BelongsToCurrentThread()) {
- callback_.Run(icon);
- } else {
- worker_task_runner_->PostTask(FROM_HERE, base::Bind(callback_, icon));
- }
-}
-
-SkBitmap NotificationImageLoader::GetDecodedImage() const {
- DCHECK(completed_);
-
- UMA_HISTOGRAM_CUSTOM_COUNTS("Notifications.Icon.FileSize", buffer_.size(), 1,
- 10000000 /* ~10mb */, 50);
-
- if (buffer_.empty())
- return SkBitmap();
-
- ImageDecoder decoder;
- return decoder.Decode(&buffer_[0], buffer_.size());
-}
-
-void NotificationImageLoader::DeleteOnCorrectThread() const {
- if (!main_task_runner_->BelongsToCurrentThread()) {
- main_task_runner_->DeleteSoon(FROM_HERE, this);
- return;
- }
-
- delete this;
-}
-
-} // namespace content

Powered by Google App Engine
This is Rietveld 408576698