third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md - Issue 1847863002: Move notification resource loading from content/child to blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

Issue 1847863002: Move notification resource loading from content/child to blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ImageFrame::getSkBitmap was removed. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('K') | « third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | third_party/WebKit/Source/platform/heap/ThreadState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

diff --git a/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md b/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

index 18812379426d61c5851ef0c6671dad09e775ac07..05ea4cb9da52591b95e07510a528735c4f0903f2 100644

--- a/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

+++ b/third_party/WebKit/Source/platform/heap/BlinkGCAPIReference.md

@@ -177,7 +177,7 @@ with a destructor.

A pre-finalizer must have the following function signature: `void preFinalizer()`. You can change the function name.

A pre-finalizer must be registered in the constructor by using the following statement:

-"`ThreadState::current()->registerPreFinalizer(preFinalizerName);`".

+"`ThreadState::current()->registerPreFinalizer(this);`".

Peter Beverloo 2016/04/13 18:32:28 Do you want to separate out this change (and the c

Michael van Ouwerkerk 2016/04/14 13:42:12 Done.

```c++

class YourClass : public GarbageCollectedFinalized<YourClass> {

@@ -185,7 +185,7 @@ class YourClass : public GarbageCollectedFinalized<YourClass> {

public:

YourClass()

{

- ThreadState::current()->registerPreFinalizer(dispose);

+ ThreadState::current()->registerPreFinalizer(this);

}

void dispose()

{