Move notification resource loading from content/child to blink

third_party/WebKit/Source/modules/notifications/NotificationImageLoader.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NotificationImageLoader_h
+#define NotificationImageLoader_h
+
+#include "core/loader/ThreadableLoader.h"
+#include "core/loader/ThreadableLoaderClient.h"
+#include "platform/SharedBuffer.h"
+#include "platform/heap/Handle.h"
+#include "third_party/skia/include/core/SkBitmap.h"
+#include "wtf/Functional.h"
+#include "wtf/OwnPtr.h"
+#include "wtf/PassOwnPtr.h"
+#include "wtf/RefPtr.h"
+
+namespace blink {
+
+class ExecutionContext;
+class KURL;
+class ResourceError;
+
+class NotificationImageLoader final

[Peter Beverloo, 2016/04/13 18:32:27]

As a meta comment, it would be nice to document classes with their purpose even
if said documentation is only two or three lines long.

[Michael van Ouwerkerk, 2016/04/14 13:42:11]

Done.

+    : public GarbageCollectedFinalized<NotificationImageLoader>
+    , public ThreadableLoaderClient {
+public:
+    // The bitmap may be empty if the request failed or the image data could not
+    // be decoded.
+    using ImageCallback = Function<void(const SkBitmap&)>;
+
+    NotificationImageLoader();
+    ~NotificationImageLoader() override;
+
+    // Asynchronously downloads an image from the given url, decodes the loaded
+    // data, and passes the bitmap to the callback.
+    void start(ExecutionContext*, const KURL&, PassOwnPtr<ImageCallback>);
+
+    // Cancels the pending load, if there is one. The |m_imageCallback| will not
+    // be run.
+    void stop();
+
+    // ThreadableLoaderClient interface.
+    void didReceiveData(const char* data, unsigned length) override;
+    void didFinishLoading(unsigned long resourceIdentifier,

[Peter Beverloo, 2016/04/13 18:32:27]

micro nit: nowrap

[Michael van Ouwerkerk, 2016/04/14 13:42:11]

Done.

+        double finishTime) override;
+    void didFail(const ResourceError&) override;
+    void didFailRedirectCheck() override;
+
+    DEFINE_INLINE_TRACE() {}
+
+private:
+    void runCallbackWithEmptyBitmap();
+
+    bool m_isStopped;
+    RefPtr<SharedBuffer> m_data;
+    OwnPtr<ImageCallback> m_imageCallback;
+    OwnPtr<ThreadableLoader> m_threadableLoader;
+};
+
+} // namespace blink
+
+#endif // NotificationImageLoader_h