third_party/WebKit/Source/modules/DEPS - Issue 1847863002: Move notification resource loading from content/child to blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/DEPS

Issue 1847863002: Move notification resource loading from content/child to blink (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ImageFrame::getSkBitmap was removed. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/child/notifications/notification_manager.cc ('K') | « content/test/data/notifications/500x500.png ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | third_party/WebKit/Source/modules/notifications/Notification.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+bindings",	2 "+bindings",

3 "+core",	3 "+core",

4 "+heap",	4 "+heap",

5 "+modules",	5 "+modules",

6 "+platform",	6 "+platform",

7 "+public/platform",	7 "+public/platform",

	8 "+skia/ext",
	Peter Beverloo 2016/04/13 18:32:27 I would be good to document in the CL description I would be good to document in the CL description why this added dependency is necessary. Michael van Ouwerkerk 2016/04/14 13:42:11 Done. Show quoted text On 2016/04/13 18:32:27, Peter Beverloo wrote: > I would be good to document in the CL description why this added dependency is > necessary. Done.
8 "-web",	9 "-web",

9 ]	10 ]

OLD	NEW